You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/17 20:08:28 UTC
Review Request: Moved checkpointing of forked PID into ExecutorLauncher and
made process isolator exec mesos-launcher.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10581/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
This is based off BenH's review: https://reviews.apache.org/r/10114/
I made it a whole new review because I didn't want to commit 2 reviews (ben's and mine).
My change is just a bug fix to pass slave's work directory to launcher.
Diffs
-----
src/launcher/launcher.hpp a527dbc867a6471b0b92521dad5adffb486a5ce4
src/launcher/launcher.cpp 57c4d3a43d77f371029600cb243e91790610af7e
src/launcher/main.cpp c99ef72bdda4a4d39015ed775ac4b7e5c659eea6
src/slave/cgroups_isolator.cpp afce79add5f0bd37b0df7000c0f728c286397aba
src/slave/process_isolator.hpp 59f87c4f2061805a3eecab25c9b2d41468552ed3
src/slave/process_isolator.cpp 7e57f24b793c7834e3a3913937308f4c25ebca70
src/slave/status_update_manager.hpp 2df28e120a2aa659eae2548d896ea949262076cb
src/slave/status_update_manager.cpp 78df5d6c21524710fb04d8a3c362589471b99873
Diff: https://reviews.apache.org/r/10581/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Moved checkpointing of forked PID into ExecutorLauncher
and made process isolator exec mesos-launcher.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10581/
-----------------------------------------------------------
(Updated April 17, 2013, 6:34 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. no need for review.
Description
-------
This is based off BenH's review: https://reviews.apache.org/r/10114/
I made it a whole new review because I didn't want to commit 2 reviews (ben's and mine).
My change is just a bug fix to pass slave's work directory to launcher.
Diffs (updated)
-----
src/launcher/launcher.hpp a527dbc867a6471b0b92521dad5adffb486a5ce4
src/launcher/launcher.cpp 57c4d3a43d77f371029600cb243e91790610af7e
src/launcher/main.cpp c99ef72bdda4a4d39015ed775ac4b7e5c659eea6
src/slave/cgroups_isolator.cpp afce79add5f0bd37b0df7000c0f728c286397aba
src/slave/process_isolator.hpp 59f87c4f2061805a3eecab25c9b2d41468552ed3
src/slave/process_isolator.cpp 7e57f24b793c7834e3a3913937308f4c25ebca70
src/slave/status_update_manager.hpp 2df28e120a2aa659eae2548d896ea949262076cb
src/slave/status_update_manager.cpp 78df5d6c21524710fb04d8a3c362589471b99873
Diff: https://reviews.apache.org/r/10581/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Moved checkpointing of forked PID into ExecutorLauncher
and made process isolator exec mesos-launcher.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10581/#review19339
-----------------------------------------------------------
Ship it!
src/launcher/launcher.cpp
<https://reviews.apache.org/r/10581/#comment40019>
Can you re-write this comment to reflect that this is no longer in the isolator?
src/slave/process_isolator.cpp
<https://reviews.apache.org/r/10581/#comment40020>
"Failed to"
- Ben Mahler
On April 17, 2013, 6:08 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10581/
> -----------------------------------------------------------
>
> (Updated April 17, 2013, 6:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> This is based off BenH's review: https://reviews.apache.org/r/10114/
>
> I made it a whole new review because I didn't want to commit 2 reviews (ben's and mine).
>
> My change is just a bug fix to pass slave's work directory to launcher.
>
>
> Diffs
> -----
>
> src/launcher/launcher.hpp a527dbc867a6471b0b92521dad5adffb486a5ce4
> src/launcher/launcher.cpp 57c4d3a43d77f371029600cb243e91790610af7e
> src/launcher/main.cpp c99ef72bdda4a4d39015ed775ac4b7e5c659eea6
> src/slave/cgroups_isolator.cpp afce79add5f0bd37b0df7000c0f728c286397aba
> src/slave/process_isolator.hpp 59f87c4f2061805a3eecab25c9b2d41468552ed3
> src/slave/process_isolator.cpp 7e57f24b793c7834e3a3913937308f4c25ebca70
> src/slave/status_update_manager.hpp 2df28e120a2aa659eae2548d896ea949262076cb
> src/slave/status_update_manager.cpp 78df5d6c21524710fb04d8a3c362589471b99873
>
> Diff: https://reviews.apache.org/r/10581/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>