[GitHub] [gobblin] umustafi commented on a change in pull request #3358: [GOBBLIN-1510] Fix Progress Reporting Behavior & Cleanup Logs

[GitBox <gi...@apache.org>]

umustafi commented on a change in pull request #3358:
URL: https://github.com/apache/gobblin/pull/3358#discussion_r685605606



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/TaskStateCollectorService.java
##########
@@ -281,7 +280,8 @@ private void reportJobProgress(TaskState taskState) {
     this.bytesCopiedSoFar += taskByteSize;
     Double newPercentageCopied = this.bytesCopiedSoFar / this.totalSizeToCopy;
 
-    if (newPercentageCopied - this.lastPercentageReported > ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD) {
+    if (newPercentageCopied - this.lastPercentageReported >= ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD ||
+        (newPercentageCopied > 1 - ConfigurationKeys.DEFAULT_PROGRESS_REPORTING_THRESHOLD && Math.abs(newPercentageCopied - this.lastPercentageReported) > 0.001)) {

Review comment:
       Agree with the points above. It's a choice essentially between if we want to report 96, 97, 98, 99, and 100 potentially or just report 95 and then 100. I did 0.001 as the threshold in case the 0.1% difference corresponds to the number being rounded up, but I did think it could be excessive like you are saying in the worst case. Any preferences? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org