You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/04/09 20:23:09 UTC
[GitHub] couchdb-fauxton pull request: Prevent overlap of text and arrows i...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/374
Prevent overlap of text and arrows in styled-select
Super minor thing. If an option in a styled select box
(.styled-select) is quite long, it will overlap the down arrow
overlay which looks kind of bad. Unfortunately browsers are
limited in that you can't put an ellipsis, so this just adds
padding instead to cut off the text, which still looks a lot
better.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton styled-select-text-overflow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/374.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #374
----
commit 4d8c33d4c110206a4b01a2fbc48048d818e132bb
Author: Ben Keen <be...@gmail.com>
Date: 2015-04-09T18:20:26Z
Prevent overlap of text and arrows in styled-select
Super minor thing. If an option in a styled select box
(.styled-select) is quite long, it will overlap the down arrow
overlay which looks kind of bad. Unfortunately browsers are
limited in that you can't put an ellipsis, so this just adds
padding instead to cut off the text, which still looks a lot
better.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Prevent overlap of text and arrows i...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/374#issuecomment-91374066
Merged as 93aa09fe288e910d2b87021f7968559058107990
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Prevent overlap of text and arrows i...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/374#issuecomment-91318023
Before:
After:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Prevent overlap of text and arrows i...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/374#issuecomment-91340791
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Prevent overlap of text and arrows i...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---