You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/08 16:51:43 UTC

[GitHub] [kafka] hachikuji commented on a diff in pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

hachikuji commented on code in PR #12598:
URL: https://github.com/apache/kafka/pull/12598#discussion_r966196258


##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -982,6 +982,12 @@ class GroupCoordinator(val brokerId: Int,
   ): Option[Errors] = {
     if (group.is(Dead)) {
       Some(Errors.COORDINATOR_NOT_AVAILABLE)
+    } else if (!isTransactional && generationId < 0 && group.is(Empty)) {

Review Comment:
   I am not sure I follow the reason for the transactional check. Can you clarify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org