You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/03/23 07:08:24 UTC
[PR] Remove SemVer [pekko-persistence-r2dbc]
mdedetrich opened a new pull request, #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99
Due to https://github.com/apache/pekko-persistence-r2dbc/issues/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016617673
> Maybe we should work out how big the changes in https://github.com/apache/pekko-persistence-r2dbc/pull/101 will be before we decide if we need this.
>
> So far the public API changes are only in pekko-projection-r2dbc and not in the pekko-persistence-r2dbc module - maybe we could just remove semver marker from pekko-projection-r2dbc.
Sure, do you want to go ahead with the PR to find out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "gstein (via GitHub)" <gi...@apache.org>.
gstein commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016671295
I removed myself as a reviewer. That was uncool @mdedetrich.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016740154
> I removed myself as a reviewer. That was uncool @mdedetrich.
Apologies, this was an accident as there is another greg as part of committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016576475
I would like to see https://github.com/apache/pekko-persistence-r2dbc/issues/90 done as it implied there is a legitimate reason why it was changed to `Long`. I'll merge this when I get home
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016591087
Maybe we should work out how big the changes in https://github.com/apache/pekko-persistence-r2dbc/pull/101 will be before we decide if we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016587953
@mdedetrich R2dbcExecutor is documented to be an internal class. For me, this means we can change its return types without too much fanfare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016461880
@pjfanning Should I go ahead and merge this as its related to an issue you are talking about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99#issuecomment-2016521420
I'm neutral on this. The change proposed in #90 is not massively impacting but I don't mind if we change the semver setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove SemVer [pekko-persistence-r2dbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #99:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org