You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2011/02/25 08:38:38 UTC

[jira] Created: (HADOOP-7155) Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.

Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.
--------------------------------------------------------------

                 Key: HADOOP-7155
                 URL: https://issues.apache.org/jira/browse/HADOOP-7155
             Project: Hadoop Common
          Issue Type: Improvement
    Affects Versions: 0.20.0
            Reporter: Konstantin Shvachko


Constant o.a.h.ipc.Server#CURRENT_VERSION defines RPC version. It should be tied to the  VersionedProtocol interface rather than the ipc.Server implementation.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HADOOP-7155) Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999460#comment-12999460 ] 

Owen O'Malley commented on HADOOP-7155:
---------------------------------------

VersionedProtocol is the base for each of the Protocols.

The Server.CURRENT_VERSION is the meta rpc version. I think it is more appropriate in Server (or Client) than in VersionedProtocol.

> Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.
> --------------------------------------------------------------
>
>                 Key: HADOOP-7155
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7155
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Shvachko
>
> Constant o.a.h.ipc.Server#CURRENT_VERSION defines RPC version. It should be tied to the  VersionedProtocol interface rather than the ipc.Server implementation.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HADOOP-7155) Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999705#comment-12999705 ] 

Konstantin Shvachko commented on HADOOP-7155:
---------------------------------------------

I agree with both of you, that Server.CURRENT_VERSION is the basis of all VersionedProtocol and that it defines the serialization format. But I don't understand why it should be defined on the Server.
If I write a new alternative server (or a client), which talks the same language as current VersionedProtocol I want to inherit the constant from the protocol, rather than the old server.
CURRENT_VERSION may also belong to Writable, I can understand that, but Server?

> Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.
> --------------------------------------------------------------
>
>                 Key: HADOOP-7155
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7155
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Shvachko
>
> Constant o.a.h.ipc.Server#CURRENT_VERSION defines RPC version. It should be tied to the  VersionedProtocol interface rather than the ipc.Server implementation.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HADOOP-7155) Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999678#comment-12999678 ] 

Hairong Kuang commented on HADOOP-7155:
---------------------------------------

Yes, I agree with Owen. Server#CURRENT_VERSION changes when we change the RPC request/response format/encoding or initial handshaking protocol etc.

> Move ipc.Server#CURRENT_VERSION constant to VersionedProtocol.
> --------------------------------------------------------------
>
>                 Key: HADOOP-7155
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7155
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Shvachko
>
> Constant o.a.h.ipc.Server#CURRENT_VERSION defines RPC version. It should be tied to the  VersionedProtocol interface rather than the ipc.Server implementation.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira