[GitHub] [kafka] C0urante commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

[GitBox <gi...@apache.org>]

C0urante commented on pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#issuecomment-969330955


   I've rebased onto the latest trunk. I think with the latest changes (especially [these logging improvements](https://github.com/apache/kafka/blob/a3ab7d5b42d02f194a8bdf3047c374f938ca0dad/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java#L479-L504)) most of the changes in this PR were made redundant. The only remaining room for improvement IMO is skipping log messages for failed tasks; the other issues (squatting on the source task offset commit thread too long for failed messages to be acknowledged, and misleading users with messages about flushing 0 records) have already been addressed.
   
   I've force-pushed a single commit that brings this PR up to date with the latest trunk; going to push an additional commit later this week that addresses the review comments that have been left on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org