You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/01 02:53:17 UTC
[GitHub] [iotdb] fuwei3140 opened a new pull request #4242: Refactor the todf() function of client_py to improve performance.
fuwei3140 opened a new pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242
## Description
Optimized the processing logic of the todf() function in client_py to read the byte stream by column to avoid performance problems caused by reading by row.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [x] been self-reviewed.
- [x] concurrent read
- [x] concurrent write
- [x] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] fuwei3140 commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
fuwei3140 commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-971325492
fix a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952691226
[](https://coveralls.io/builds/44326488)
Coverage decreased (-0.4%) to 66.536% when pulling **6c05496136c0160f442942a0856713272594fe4d on fuwei3140:client-py-fix** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] fuwei3140 commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
fuwei3140 commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-955881369
This is a good proposal, and a complete test is necessary @JulianFeinauer . I can try to use pytest to implement tests on various data type queries. @SteveYurongSu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] fuwei3140 closed pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
fuwei3140 closed pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4242: Refactor the todf() function of client-py to improve performance
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952691226
[](https://coveralls.io/builds/44401023)
Coverage increased (+0.03%) to 66.927% when pulling **3d958631a34296306452ceee1ca943319c388f5e on fuwei3140:client-py-fix** into **7ff968cf43222f2dc5fe04524ce9753c55abeaa5 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952691226
[](https://coveralls.io/builds/44117886)
Coverage decreased (-0.2%) to 66.76% when pulling **6255d857b8c617f4a9183ec319cab00805998ad6 on fuwei3140:client-py-fix** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952691226
[](https://coveralls.io/builds/44325469)
Coverage decreased (-0.4%) to 66.502% when pulling **c6ff26e0f9a01321af1f165949dec39b92ffcab7 on fuwei3140:client-py-fix** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-955891573
> This is a good proposal, and a complete test is necessary @JulianFeinauer . I can try to use pytest to implement tests on various data type queries. @SteveYurongSu
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] fuwei3140 commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
fuwei3140 commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-963906314
Hello @JulianFeinauer @SteveYurongSu ,
1.Added test cases to verify query operations of multiple data types, simple queries, queries with null values, and multiple batch queries.
2.Modify the null value handling of the dataframe. In the original implementation, when the data type is INT32, INT64, and BOOLEAN, using 0 and False instead of null values will mislead users and fail to recognize null values. Because numpy does not support null values of this types, the new implementation is to use pd.NA instead of null values of this data types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] fuwei3140 commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
fuwei3140 commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-955880800
> Thanks for pinging me @SteveYurongSu . The code looks so far fine for me. What wee are generally missing in our python module are tests (we effectively have none). So I really would appreciate any test (based on pytest) to be added to the repo. What do you think @fuwei3140 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952691226
[](https://coveralls.io/builds/43804011)
Coverage increased (+0.04%) to 66.957% when pulling **611e82ea4179d66471168157f49a697b4bcb082f on fuwei3140:client-py-fix** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952649592
Hi, @JulianFeinauer
Please take a look :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JulianFeinauer commented on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-955672782
Thanks for pinging me @SteveYurongSu . The code looks so far fine for me. What wee are generally missing in our python module are tests (we effectively have none). So I really would appreciate any test (based on pytest) to be added to the repo. What do you think @fuwei3140 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-952691226
[](https://coveralls.io/builds/43902570)
Coverage decreased (-0.04%) to 66.88% when pulling **611e82ea4179d66471168157f49a697b4bcb082f on fuwei3140:client-py-fix** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] fuwei3140 removed a comment on pull request #4242: Refactor the todf() function of client_py to improve performance.
Posted by GitBox <gi...@apache.org>.
fuwei3140 removed a comment on pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242#issuecomment-955880800
> Thanks for pinging me @SteveYurongSu . The code looks so far fine for me. What wee are generally missing in our python module are tests (we effectively have none). So I really would appreciate any test (based on pytest) to be added to the repo. What do you think @fuwei3140 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4242: Refactor the todf() function of client-py to improve performance
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4242:
URL: https://github.com/apache/iotdb/pull/4242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org