You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/01/05 14:03:48 UTC
Re: Review Request 71885: Updated the `update()` method of subsystem
to handle resource limits.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71885/
-----------------------------------------------------------
(Updated Jan. 5, 2020, 10:03 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Changed the `resourcelimits` parameter to not use `Option`.
Bugs: MESOS-10067
https://issues.apache.org/jira/browse/MESOS-10067
Repository: mesos
Description
-------
Updated the `update()` method of subsystem to handle resource limits.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e
src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp a311ab4495f71bedacd2e99c84c765f0e5fe99d3
src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1
src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp 02e7163b9a7a928352715848947e608885c5242a
src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 960bd141430387e076a8fab1948d07719613ed90
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 27d88e91fb784179effd54781f84000fe85c13eb
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 0896d37761a11f55ba4b866d235c3bd2b79dcfba
Diff: https://reviews.apache.org/r/71885/diff/2/
Changes: https://reviews.apache.org/r/71885/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71885: Updated the `update()` method of subsystem
to handle resource limits.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71885/
-----------------------------------------------------------
(Updated March 16, 2020, 5:06 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Rebased.
Bugs: MESOS-10067
https://issues.apache.org/jira/browse/MESOS-10067
Repository: mesos
Description
-------
Updated the `update()` method of subsystem to handle resource limits.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp bf2a4d8d587969568f451f63e4f619e9c49f3642
src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp a311ab4495f71bedacd2e99c84c765f0e5fe99d3
src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1
src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp 02e7163b9a7a928352715848947e608885c5242a
src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 960bd141430387e076a8fab1948d07719613ed90
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 27d88e91fb784179effd54781f84000fe85c13eb
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 0896d37761a11f55ba4b866d235c3bd2b79dcfba
Diff: https://reviews.apache.org/r/71885/diff/3/
Changes: https://reviews.apache.org/r/71885/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71885: Updated the `update()` method of subsystem
to handle resource limits.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71885/#review219790
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 5, 2020, 2:03 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71885/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2020, 2:03 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10067
> https://issues.apache.org/jira/browse/MESOS-10067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the `update()` method of subsystem to handle resource limits.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp a311ab4495f71bedacd2e99c84c765f0e5fe99d3
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp dc6c7aa1c998c30c8b17db04a38e7a1e28a6a6c1
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp 02e7163b9a7a928352715848947e608885c5242a
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 960bd141430387e076a8fab1948d07719613ed90
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 27d88e91fb784179effd54781f84000fe85c13eb
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 0896d37761a11f55ba4b866d235c3bd2b79dcfba
>
>
> Diff: https://reviews.apache.org/r/71885/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>