You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/06/11 06:03:10 UTC
[GitHub] [kylin] codecov-io commented on issue #681: KYLIN-4039,
fix ZK distributed lock may not release lock
codecov-io commented on issue #681: KYLIN-4039, fix ZK distributed lock may not release lock
URL: https://github.com/apache/kylin/pull/681#issuecomment-500699377
# [Codecov](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=h1) Report
> Merging [#681](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/8efa5583f4026291789e5df090202bbc06b9bad7?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `39.02%`.
[](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #681 +/- ##
===========================================
+ Coverage 25.73% 25.8% +0.06%
- Complexity 6010 6032 +22
===========================================
Files 1384 1390 +6
Lines 82382 82482 +100
Branches 11551 11555 +4
===========================================
+ Hits 21200 21283 +83
- Misses 59138 59154 +16
- Partials 2044 2045 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/kylin/job/util/ThrowableUtils.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL1Rocm93YWJsZVV0aWxzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ck/zookeeper/exception/ZkAcquireLockException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtBY3F1aXJlTG9ja0V4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../lock/zookeeper/exception/ZkPeekLockException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtQZWVrTG9ja0V4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...keeper/exception/ZkPeekLockInterruptException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtQZWVrTG9ja0ludGVycnVwdEV4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | |
| [...per/exception/ZkReleaseLockInterruptException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtSZWxlYXNlTG9ja0ludGVycnVwdEV4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | |
| [...ck/zookeeper/exception/ZkReleaseLockException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtSZWxlYXNlTG9ja0V4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | |
| [...n/job/lock/zookeeper/ZookeeperDistributedLock.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9ab29rZWVwZXJEaXN0cmlidXRlZExvY2suamF2YQ==) | `55.47% <61.76%> (+55.47%)` | `18 <5> (+18)` | :arrow_up: |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=footer). Last update [8efa558...978a230](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services