You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gary Helmling (JIRA)" <ji...@apache.org> on 2011/01/06 20:32:45 UTC

[jira] Created: (HBASE-3424) Add metrics for custom RPC methods called through HTable.coprocessorExec()

Add metrics for custom RPC methods called through HTable.coprocessorExec()
--------------------------------------------------------------------------

                 Key: HBASE-3424
                 URL: https://issues.apache.org/jira/browse/HBASE-3424
             Project: HBase
          Issue Type: Sub-task
            Reporter: Gary Helmling




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (HBASE-3424) Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-3424:
----------------------------------

    Issue Type: Improvement  (was: Sub-task)
        Parent:     (was: HBASE-2000)

> Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-3424
>                 URL: https://issues.apache.org/jira/browse/HBASE-3424
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors, ipc
>            Reporter: Gary Helmling
>            Priority: Minor
>
> Currently HBaseRpcMetrics only reports on known RPC methods in core HBase.  With HBASE-3405 we added hooks to register metrics for new methods.  We can make use of these for tabulating metrics on custom CoprocessorProtocol extensions invoked through HTable.coprocessorProxy() and HTable.coprocessorExec().

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HBASE-3424) Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()

Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Helmling updated HBASE-3424:
---------------------------------

    Component/s: ipc
    Description: Currently HBaseRpcMetrics only reports on known RPC methods in core HBase.  With HBASE-3405 we added hooks to register metrics for new methods.  We can make use of these for tabulating metrics on custom CoprocessorProtocol extensions invoked through HTable.coprocessorProxy() and HTable.coprocessorExec().
       Priority: Minor  (was: Major)
        Summary: Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()  (was: Add metrics for custom RPC methods called through HTable.coprocessorExec())

> Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-3424
>                 URL: https://issues.apache.org/jira/browse/HBASE-3424
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Gary Helmling
>            Priority: Minor
>
> Currently HBaseRpcMetrics only reports on known RPC methods in core HBase.  With HBASE-3405 we added hooks to register metrics for new methods.  We can make use of these for tabulating metrics on custom CoprocessorProtocol extensions invoked through HTable.coprocessorProxy() and HTable.coprocessorExec().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3424) Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()

Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Helmling updated HBASE-3424:
---------------------------------

    Component/s: coprocessors

> Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-3424
>                 URL: https://issues.apache.org/jira/browse/HBASE-3424
>             Project: HBase
>          Issue Type: Sub-task
>          Components: coprocessors, ipc
>            Reporter: Gary Helmling
>            Priority: Minor
>
> Currently HBaseRpcMetrics only reports on known RPC methods in core HBase.  With HBASE-3405 we added hooks to register metrics for new methods.  We can make use of these for tabulating metrics on custom CoprocessorProtocol extensions invoked through HTable.coprocessorProxy() and HTable.coprocessorExec().

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HBASE-3424) Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()

Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998982#comment-12998982 ] 

Otis Gospodnetic commented on HBASE-3424:
-----------------------------------------

I don't follow if this issue represents something that needs to be implemented?  It sounds like it's just pointing to HBASE-3405.  Or maybe this is a placeholder for future patches for metrics around Coprocessors?


> Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-3424
>                 URL: https://issues.apache.org/jira/browse/HBASE-3424
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Gary Helmling
>            Priority: Minor
>
> Currently HBaseRpcMetrics only reports on known RPC methods in core HBase.  With HBASE-3405 we added hooks to register metrics for new methods.  We can make use of these for tabulating metrics on custom CoprocessorProtocol extensions invoked through HTable.coprocessorProxy() and HTable.coprocessorExec().

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HBASE-3424) Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()

Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998988#comment-12998988 ] 

Gary Helmling commented on HBASE-3424:
--------------------------------------

Sorry, I skipped quite a bit of background explanation here.  Yes, this still needs to be implemented within the coprocessor framework -- specifically within {{HRegion.exec()}}.

The idea is that if you define a custom protocol for your coprocessor, like:
{noformat}
public interface RowCountProtocol extends CoprocessorProtocol {
    public long count();
    public long countForQualifier(byte[] family, byte[] qualifier)
}
{noformat}

This is ultimately invoked on the region server by a call to {{HRegionInterface.execCoprocessor()}}.  Current RPC metrics would contains stats for the number of invocations of {{execCoprocessor()}} but this doesn't tell you anything about what {{RowCountProtocol}} method was actually invoked.

So in {{HRegion.exec()}} we would add some code to increment metrics on the wrapped {{RowCountProtocol}} method being called by {{Method.invoke()}}.  Then you would also have individual RPC metrics for {{RowCountProtocol.count()}} and {{RowCountProtocol.countForQualifier()}}.

> Coprocessors: Add metrics for custom RPC methods called through HTable.coprocessorExec()
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-3424
>                 URL: https://issues.apache.org/jira/browse/HBASE-3424
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Gary Helmling
>            Priority: Minor
>
> Currently HBaseRpcMetrics only reports on known RPC methods in core HBase.  With HBASE-3405 we added hooks to register metrics for new methods.  We can make use of these for tabulating metrics on custom CoprocessorProtocol extensions invoked through HTable.coprocessorProxy() and HTable.coprocessorExec().

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira