You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Stephen Gargan (JIRA)" <ji...@apache.org> on 2010/10/24 21:56:19 UTC
[jira] Created: (AVRO-683) Specify types in static factory methods
in Requestors
Specify types in static factory methods in Requestors
-----------------------------------------------------
Key: AVRO-683
URL: https://issues.apache.org/jira/browse/AVRO-683
Project: Avro
Issue Type: Improvement
Affects Versions: 1.5.0
Reporter: Stephen Gargan
Priority: Trivial
Fix For: 1.5.0
Attachments: typed-requestors.patch
The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
becomes
TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-683) Specify types in static factory methods
in Requestors
Posted by "Stephen Gargan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Gargan updated AVRO-683:
--------------------------------
Attachment: typed-requestors.patch
> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
> Key: AVRO-683
> URL: https://issues.apache.org/jira/browse/AVRO-683
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Priority: Trivial
> Fix For: 1.5.0
>
> Attachments: typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AVRO-683) Specify types in static factory methods
in Requestors
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting reassigned AVRO-683:
---------------------------------
Assignee: Stephen Gargan
> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
> Key: AVRO-683
> URL: https://issues.apache.org/jira/browse/AVRO-683
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Trivial
> Fix For: 1.5.0
>
> Attachments: typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-683) Specify types in static factory methods
in Requestors
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved AVRO-683.
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I just committed this. Thanks, Stephen.
> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
> Key: AVRO-683
> URL: https://issues.apache.org/jira/browse/AVRO-683
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Trivial
> Fix For: 1.5.0
>
> Attachments: typed-requestors-whitespace.patch, typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-683) Specify types in static factory methods
in Requestors
Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Carey updated AVRO-683:
-----------------------------
Component/s: java
> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
> Key: AVRO-683
> URL: https://issues.apache.org/jira/browse/AVRO-683
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Trivial
> Fix For: 1.5.0
>
> Attachments: typed-requestors-whitespace.patch, typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-683) Specify types in static factory methods
in Requestors
Posted by "Stephen Gargan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Gargan updated AVRO-683:
--------------------------------
Attachment: typed-requestors-whitespace.patch
Doug,
I've made the changes you suggested in the attached patch.
Thanks.
Steve.
> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
> Key: AVRO-683
> URL: https://issues.apache.org/jira/browse/AVRO-683
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Assignee: Stephen Gargan
> Priority: Trivial
> Fix For: 1.5.0
>
> Attachments: typed-requestors-whitespace.patch, typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-683) Specify types in static factory
methods in Requestors
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924647#action_12924647 ]
Doug Cutting commented on AVRO-683:
-----------------------------------
Overall this looks like a good improvement.
A few small improvements I'd like to see before we commit this.
- There are some whitespace-only changes to ReflectRequestor. Can you please remove these?
- We should try to use @SuppressWarnings("unchecked") as narrowly as possible. Please move this declaration to just those methods that require it.
Thanks!
> Specify types in static factory methods in Requestors
> -----------------------------------------------------
>
> Key: AVRO-683
> URL: https://issues.apache.org/jira/browse/AVRO-683
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.5.0
> Reporter: Stephen Gargan
> Priority: Trivial
> Fix For: 1.5.0
>
> Attachments: typed-requestors.patch
>
>
> The attached patch adds type information to the static factory methods in the SpecificRequestor and ReflectRequestor to avoid the necessity of casting the proxy.
> TestNamespace proxy = (TestNamespace)SpecificRequestor.getClient(TestNamespace.class, client);
> becomes
> TestNamespace proxy = SpecificRequestor.getClient(TestNamespace.class, client);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.