[GitHub] reddycharan commented on issue #1092: Dont log ledgermetadata which contains password.

[GitBox <gi...@apache.org>]

reddycharan commented on issue #1092: Dont log ledgermetadata which contains password.
URL: https://github.com/apache/bookkeeper/pull/1092#issuecomment-362079539
 
 
   yeah, even I've mixed opinion on the fix for it. We are getting string representation of LedgerMetadata from the serialize method and its underlying methods. I don't feel it is correct to change the logic there. Probably a new method can be added to LedgerMetadata say "toSafeString" which would call toString method and filter out 'password' field if it is present. It is going to be hacky, but I don't see any better solution if we want to continue logging the changed metadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services