You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/15 17:59:53 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10864: KAFKA-12155 Metadata log and snapshot cleaning

cmccabe commented on a change in pull request #10864:
URL: https://github.com/apache/kafka/pull/10864#discussion_r652028042



##########
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##########
@@ -253,7 +253,8 @@ class KafkaRaftManager[T](
       time,
       scheduler,
       maxBatchSizeInBytes = KafkaRaftClient.MAX_BATCH_SIZE_BYTES,
-      maxFetchSizeInBytes = KafkaRaftClient.MAX_FETCH_SIZE_BYTES
+      maxFetchSizeInBytes = KafkaRaftClient.MAX_FETCH_SIZE_BYTES,
+      config = MetadataLogConfig(config)

Review comment:
       should maxBatchSizeInBytes be part of MetadataLogConfig?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org