You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2019/01/08 02:06:38 UTC
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12177
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
To facilitate correlating test failures (where we sometimes know things
like fragment id) with the tests that generated those queries, we can
stuff the test name into CLIENT_IDENTIFIER.
The mechanics here are to create a global, tests.common.current_node to
store the current test, create a plugin in conftest to set this when
entering a test, and then configuring connections as they're created
deep in test code.
Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
---
M tests/common/impala_connection.py
M tests/conftest.py
M tests/query_test/test_observability.py
3 files changed, 32 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12177/1
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1734/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 02:44:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
To facilitate correlating test failures (where we sometimes know things
like fragment id) with the tests that generated those queries, we can
stuff the test name into CLIENT_IDENTIFIER.
The mechanics here are to create a global, tests.common.current_node to
store the current test, create a plugin in conftest to set this when
entering a test, and then configuring connections as they're created
deep in test code.
Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Reviewed-on: http://gerrit.cloudera.org:8080/12177
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_connection.py
M tests/conftest.py
M tests/query_test/test_observability.py
3 files changed, 34 insertions(+), 5 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py
File tests/conftest.py:
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py@595
PS1, Line 595: @pytest.hookimpl(trylast=True)
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py@601
PS1, Line 601: ,
flake8: E231 missing whitespace after ','
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py@601
PS1, Line 601: :
flake8: E501 line too long (95 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 02:07:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3631/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 01:39:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 1: Code-Review+1
Actually I'll let david have a look, I can upgrade to +2 if he does'nt want to.
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 23:55:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 23:55:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1753/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 20:06:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 05:34:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 01:40:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12177
to look at the new patch set (#2).
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
To facilitate correlating test failures (where we sometimes know things
like fragment id) with the tests that generated those queries, we can
stuff the test name into CLIENT_IDENTIFIER.
The mechanics here are to create a global, tests.common.current_node to
store the current test, create a plugin in conftest to set this when
entering a test, and then configuring connections as they're created
deep in test code.
Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
---
M tests/common/impala_connection.py
M tests/conftest.py
M tests/query_test/test_observability.py
3 files changed, 34 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12177/2
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7666: Propagate name of test into CLIENT IDENTIFIER.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12177 )
Change subject: IMPALA-7666: Propagate name of test into CLIENT_IDENTIFIER.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py
File tests/conftest.py:
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py@595
PS1, Line 595: @pytest.hookimpl(trylast=True)
> flake8: E302 expected 2 blank lines, found 1
Done
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py@601
PS1, Line 601: ,
> flake8: E231 missing whitespace after ','
Done
http://gerrit.cloudera.org:8080/#/c/12177/1/tests/conftest.py@601
PS1, Line 601: :
> flake8: E501 line too long (95 > 90 characters)
Done
--
To view, visit http://gerrit.cloudera.org:8080/12177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f685fd16982d73ad3fc0f4a7578c5ad83b9a84c
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 19:04:42 +0000
Gerrit-HasComments: Yes