[GitHub] [pinot] snleee commented on a diff in pull request #10290: Add a tight retry block to update ZK during endSegmentReplacement

["snleee (via GitHub)" <gi...@apache.org>]

snleee commented on code in PR #10290:
URL: https://github.com/apache/pinot/pull/10290#discussion_r1108889975


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3433,31 +3433,16 @@ public String startReplaceSegments(String tableNameWithType, List<String> segmen
   public void endReplaceSegments(String tableNameWithType, String segmentLineageEntryId) {
     try {
       DEFAULT_RETRY_POLICY.attempt(() -> {

Review Comment:
   Good point. We still need to keep the top level retry logic to be backward compatible. 
   
   - I have seen the cases where waiting for segments to become online takes ~30minutes (think about the refresh push for TBs of data). 
   - Previous implementation was doing the retry for 5 times + wait 10 minutes for each round so we will be successful.
   - If we remove the top level, we will fail after 10min waiting time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org