You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/01 16:15:29 UTC

[GitHub] [kafka] xvrl commented on a change in pull request #10937: KAFKA-10587 Rename kafka-mirror-maker CLI command line arguments for KIP-629

xvrl commented on a change in pull request #10937:
URL: https://github.com/apache/kafka/pull/10937#discussion_r662425926



##########
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##########
@@ -454,8 +454,8 @@ object MirrorMaker extends Logging with KafkaMetricsGroup {
       .ofType(classOf[java.lang.Integer])
       .defaultsTo(1)
 
-    val whitelistOpt = parser.accepts("whitelist",
-      "Whitelist of topics to mirror.")
+    val includeOpt = parser.accepts("include",

Review comment:
       we should deprecate the old argument, but provide backwards compatibility until we remove it in a future release.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org