You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by John Speidel <js...@hortonworks.com> on 2016/06/03 21:46:19 UTC
Review Request 48231: Unable to delete terms via API which are 3 or
more levels deep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48231/
-----------------------------------------------------------
Review request for atlas and Hemanth Yamijala.
Bugs: ATLAS-858
https://issues.apache.org/jira/browse/ATLAS-858
Repository: atlas
Description
-------
Attempting to delete a term that is 3 or more levels deep results in an error response:
DELETE api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111
405 - Method Not Allowed
This is because I for got to add a service method for deleting sub terms.
Diffs
-----
webapp/pom.xml 6b0a927
webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 83bbd22
webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 1ea8e14
webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 04cabad
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/48231/diff/
Testing
-------
- Added new tests for TaxonomyService including a test for the new delete method
- All existing unit tests pass
- All manual functional tests pass
Thanks,
John Speidel
Re: Review Request 48231: Unable to delete terms via API which are 3
or more levels deep
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48231/#review136119
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java (line 132)
<https://reviews.apache.org/r/48231/#comment201127>
Having return type as 'CatalogRuntimeException' might make the purpose of this method explicit. Please review.
- Madhan Neethiraj
On June 3, 2016, 9:46 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48231/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 9:46 p.m.)
>
>
> Review request for atlas and Hemanth Yamijala.
>
>
> Bugs: ATLAS-858
> https://issues.apache.org/jira/browse/ATLAS-858
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Attempting to delete a term that is 3 or more levels deep results in an error response:
>
> DELETE api/atlas/v1/taxonomies/taxonomy1/terms/term1/terms/term11/terms/term111
> 405 - Method Not Allowed
>
> This is because I for got to add a service method for deleting sub terms.
>
>
> Diffs
> -----
>
> webapp/pom.xml 6b0a927
> webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java 83bbd22
> webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 1ea8e14
> webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 04cabad
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/48231/diff/
>
>
> Testing
> -------
>
> - Added new tests for TaxonomyService including a test for the new delete method
> - All existing unit tests pass
> - All manual functional tests pass
>
>
> Thanks,
>
> John Speidel
>
>