You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/15 22:37:50 UTC

[GitHub] [arrow-datafusion] houqp opened a new issue #892: support join conditions in where clause

houqp opened a new issue #892:
URL: https://github.com/apache/arrow-datafusion/issues/892


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   tpch query 8 is taking forever to execute in ballista because its subquery is planned as a cross join across 8 tables.
   
   **Describe the solution you'd like**
   
   The join conditions for query 8 are specified in the where clause. Our optimizer should pick this up and rewrite the cross join into inner join.
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Surfaced from https://github.com/apache/arrow-datafusion/pull/891.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] houqp commented on issue #892: support join conditions in where clause

Posted by GitBox <gi...@apache.org>.
houqp commented on issue #892:
URL: https://github.com/apache/arrow-datafusion/issues/892#issuecomment-968177538


   You are right @xudong963. I think there is a bug in that rewrite that resulted in inefficient cross join in an edge-case. I filed https://github.com/apache/arrow-datafusion/issues/1293 to track that problem instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] xudong963 commented on issue #892: support join conditions in where clause

Posted by GitBox <gi...@apache.org>.
xudong963 commented on issue #892:
URL: https://github.com/apache/arrow-datafusion/issues/892#issuecomment-968056340


   If I read right, the issue has been solved? https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/sql/planner.rs#L691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] xudong963 commented on issue #892: support join conditions in where clause

Posted by GitBox <gi...@apache.org>.
xudong963 commented on issue #892:
URL: https://github.com/apache/arrow-datafusion/issues/892#issuecomment-939211191


   @houqp  I want to try it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] houqp closed issue #892: support join conditions in where clause

Posted by GitBox <gi...@apache.org>.
houqp closed issue #892:
URL: https://github.com/apache/arrow-datafusion/issues/892


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org