You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/18 12:43:59 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1139:
bugfix: checked `consumer` first,
it maybe a boolean value when it was beed deleted.
membphis opened a new pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1139: bugfix:
checked `consumer` first, it maybe a boolean value when it was beed deleted.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139#issuecomment-587442308
fix https://github.com/apache/incubator-apisix/issues/1138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1139: bugfix:
checked `consumer` first, it maybe a boolean value when it was beed deleted.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139#issuecomment-587451030
> Will other objects have similar problem? for example delete route
https://github.com/apache/incubator-apisix/blob/master/lua/apisix/core/config_etcd.lua#L284
the old object will be set to boolean value if it was deleted or expired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1139: bugfix: checked `consumer` first,
it maybe a boolean value when it was beed deleted.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139#discussion_r380655099
##########
File path: lua/apisix/consumer.lua
##########
@@ -35,6 +36,10 @@ local function plugin_consumer()
end
for _, consumer in ipairs(consumers.values) do
+ if type(consumer) ~= "table" then
Review comment:
```
if type(consumer) == "table" then
for ...
end
```
is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1139: bugfix: checked `consumer` first,
it maybe a boolean value when it was beed deleted.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139#discussion_r381813297
##########
File path: lua/apisix/consumer.lua
##########
@@ -35,6 +36,10 @@ local function plugin_consumer()
end
for _, consumer in ipairs(consumers.values) do
+ if type(consumer) ~= "table" then
Review comment:
The current code style is to reduce indentation. I prefer the current coding style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1139: bugfix:
checked `consumer` first, it maybe a boolean value when it was beed deleted.
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139#issuecomment-587449058
Will other objects have similar problem? for example delete route
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming merged pull request #1139: bugfix:
checked `consumer` first, it maybe a boolean value when it was beed deleted.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services