You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/11/10 11:22:03 UTC
Review Request 63722: Remove IPA integration from experimental status
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.
Bugs: AMBARI-22412
https://issues.apache.org/jira/browse/AMBARI-22412
Repository: ambari
Description
-------
Remove IPA integration from experimental status so that users can select FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having to explicitly enable it via the Experimental page.
Diffs
-----
ambari-web/app/config.js 0963f7094a
ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774
ambari-web/app/messages.js bee581aefa
ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js ca80341780
Diff: https://reviews.apache.org/r/63722/diff/1/
Testing
-------
Manually tested
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:38 min
[INFO] Finished at: 2017-11-10T06:04:05-05:00
[INFO] Final Memory: 30M/1361M
[INFO] ------------------------------------------------------------------------
```
Thanks,
Robert Levas
Re: Review Request 63722: Remove IPA integration from experimental
status
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/#review190720
-----------------------------------------------------------
Ship it!
Ship It!
- Eugene Chekanskiy
On Nov. 10, 2017, 11:22 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63722/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 11:22 a.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-22412
> https://issues.apache.org/jira/browse/AMBARI-22412
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove IPA integration from experimental status so that users can select FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having to explicitly enable it via the Experimental page.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 0963f7094a
> ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774
> ambari-web/app/messages.js bee581aefa
> ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js ca80341780
>
>
> Diff: https://reviews.apache.org/r/63722/diff/1/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 04:38 min
> [INFO] Finished at: 2017-11-10T06:04:05-05:00
> [INFO] Final Memory: 30M/1361M
> [INFO] ------------------------------------------------------------------------
> ```
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 63722: Remove IPA integration from experimental
status
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/
-----------------------------------------------------------
(Updated Nov. 10, 2017, 10:43 a.m.)
Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.
Bugs: AMBARI-22412
https://issues.apache.org/jira/browse/AMBARI-22412
Repository: ambari
Description
-------
Remove IPA integration from experimental status so that users can select FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having to explicitly enable it via the Experimental page.
Diffs
-----
ambari-web/app/config.js 0963f7094a
ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774
ambari-web/app/messages.js bee581aefa
ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js ca80341780
Diff: https://reviews.apache.org/r/63722/diff/1/
Testing (updated)
-------
Manually tested
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:38 min
[INFO] Finished at: 2017-11-10T06:04:05-05:00
[INFO] Final Memory: 30M/1361M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results:
```
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12897064/AMBARI-22412_trunk_01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in ambari-web.
```
Thanks,
Robert Levas
Re: Review Request 63722: Remove IPA integration from experimental
status
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/#review190719
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Nov. 10, 2017, 11:22 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63722/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 11:22 a.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-22412
> https://issues.apache.org/jira/browse/AMBARI-22412
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove IPA integration from experimental status so that users can select FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having to explicitly enable it via the Experimental page.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 0963f7094a
> ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774
> ambari-web/app/messages.js bee581aefa
> ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js ca80341780
>
>
> Diff: https://reviews.apache.org/r/63722/diff/1/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 04:38 min
> [INFO] Finished at: 2017-11-10T06:04:05-05:00
> [INFO] Final Memory: 30M/1361M
> [INFO] ------------------------------------------------------------------------
> ```
>
>
> Thanks,
>
> Robert Levas
>
>