You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/04/01 09:17:22 UTC
[GitHub] flink pull request #5798: [FLINK-7917] The return of taskInformationOrBlobKe...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5798
[FLINK-7917] The return of taskInformationOrBlobKey should be placed inside synchronized in ExecutionJobVertex
## What is the purpose of the change
*This pull request placed the taskInformationOrBlobKey inside synchronized in ExecutionJobVertex*
## Brief change log
- *Placed the taskInformationOrBlobKey inside synchronized in ExecutionJobVertex*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-7917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5798
----
commit 041d5cc36a502e23b3c01f4066566174b4d86598
Author: yanghua <ya...@...>
Date: 2018-04-01T09:14:50Z
[FLINK-7917] The return of taskInformationOrBlobKey should be placed inside synchronized in ExecutionJobVertex
----
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @tzulitai
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @StefanRRichter
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5798
+1, merging
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @kl0u
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @zentol
---
[GitHub] flink pull request #5798: [FLINK-7917] The return of taskInformationOrBlobKe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5798
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5798
Thanks for the fix @yanghua and the review @dawidwys.
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @zentol @GJL @tzulitai this PR takes a long time, please review thanks~
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @tillrohrmann
---
[GitHub] flink issue #5798: [FLINK-7917] The return of taskInformationOrBlobKey shoul...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5798
cc @zentol
---