You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/26 09:01:35 UTC

[GitHub] [incubator-inlong] shink opened a new pull request #2748: [INLONG2747][Feature][CI]: Add support for uploading binary package

shink opened a new pull request #2748:
URL: https://github.com/apache/incubator-inlong/pull/2748


   fix: #2747
   
   ### Motivation
   
   Add support for uploading binary package when building the project on GitHub Actions.
   
   ### Modifications
   
   - `.github/workflows/ci_build.yml`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] dockerzhang merged pull request #2748: [INLONG-2747][Feature][CI]: Add support for uploading binary package

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2748:
URL: https://github.com/apache/incubator-inlong/pull/2748


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] shink commented on a change in pull request #2748: [INLONG2747][Feature][CI]: Add support for uploading binary package

Posted by GitBox <gi...@apache.org>.
shink commented on a change in pull request #2748:
URL: https://github.com/apache/incubator-inlong/pull/2748#discussion_r815289259



##########
File path: .github/workflows/ci_build.yml
##########
@@ -49,4 +49,17 @@ jobs:
       - name: Build with Maven
         run: mvn --batch-mode --update-snapshots -e -V clean install -DskipTests
         env:
-          CI: false
\ No newline at end of file
+          CI: false
+
+      - name: Get inlong version
+        if: ${{ success() }}
+        run: |
+          version=`mvn -Dexec.executable='echo' -Dexec.args='${project.version}' --non-recursive exec:exec -q`
+          echo "VERSION=${version}" >> $GITHUB_ENV
+
+      - name: Upload binary package
+        if: ${{ success() }}
+        uses: actions/upload-artifact@v2
+        with:
+          name: apache-inlong-${{ env.VERSION }}-bin.tar.gz
+          path: ./inlong-distribution/target/apache-inlong-${{ env.VERSION }}-bin.tar.gz

Review comment:
       @dockerzhang Is this binary filename available?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org