You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Eric Johnson (JIRA)" <ji...@apache.org> on 2011/03/30 01:03:05 UTC

[jira] [Created] (AXIOM-359) OMProcessingInstructionImpl incorrectly trims the value passed in the constructor

OMProcessingInstructionImpl incorrectly trims the value passed in the constructor
---------------------------------------------------------------------------------

                 Key: AXIOM-359
                 URL: https://issues.apache.org/jira/browse/AXIOM-359
             Project: Axiom
          Issue Type: Bug
          Components: LLOM
    Affects Versions: 1.2.11
            Reporter: Eric Johnson
            Priority: Minor


When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:

        this.value = (value == null) ? null : value.trim();

In fact, it should do this:

        this.value = (value == null) ? null : value;

(That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (AXIOM-359) OMProcessingInstructionImpl incorrectly trims the value passed in the constructor

Posted by "Eric Johnson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIOM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Johnson updated AXIOM-359:
-------------------------------

    Description: 
When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/ ), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:

        this.value = (value == null) ? null : value.trim();

In fact, it should do this:

        this.value = (value == null) ? null : value;

(That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

  was:
When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:

        this.value = (value == null) ? null : value.trim();

In fact, it should do this:

        this.value = (value == null) ? null : value;

(That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.


Updated the description to fix the link to santuario-genxdm

> OMProcessingInstructionImpl incorrectly trims the value passed in the constructor
> ---------------------------------------------------------------------------------
>
>                 Key: AXIOM-359
>                 URL: https://issues.apache.org/jira/browse/AXIOM-359
>             Project: Axiom
>          Issue Type: Bug
>          Components: LLOM
>    Affects Versions: 1.2.11
>            Reporter: Eric Johnson
>            Priority: Minor
>
> When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/ ), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:
>         this.value = (value == null) ? null : value.trim();
> In fact, it should do this:
>         this.value = (value == null) ? null : value;
> (That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (AXIOM-359) OMProcessingInstructionImpl incorrectly trims the value passed in the constructor

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIOM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen updated AXIOM-359:
----------------------------------

    Fix Version/s: 1.2.12
         Assignee: Andreas Veithen

> OMProcessingInstructionImpl incorrectly trims the value passed in the constructor
> ---------------------------------------------------------------------------------
>
>                 Key: AXIOM-359
>                 URL: https://issues.apache.org/jira/browse/AXIOM-359
>             Project: Axiom
>          Issue Type: Bug
>          Components: LLOM
>    Affects Versions: 1.2.11
>            Reporter: Eric Johnson
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2.12
>
>
> When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/ ), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:
>         this.value = (value == null) ? null : value.trim();
> In fact, it should do this:
>         this.value = (value == null) ? null : value;
> (That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Resolved] (AXIOM-359) OMProcessingInstructionImpl incorrectly trims the value passed in the constructor

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIOM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIOM-359.
-----------------------------------

    Resolution: Fixed

> OMProcessingInstructionImpl incorrectly trims the value passed in the constructor
> ---------------------------------------------------------------------------------
>
>                 Key: AXIOM-359
>                 URL: https://issues.apache.org/jira/browse/AXIOM-359
>             Project: Axiom
>          Issue Type: Bug
>          Components: LLOM
>    Affects Versions: 1.2.11
>            Reporter: Eric Johnson
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2.12
>
>
> When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/ ), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:
>         this.value = (value == null) ? null : value.trim();
> In fact, it should do this:
>         this.value = (value == null) ? null : value;
> (That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Work started] (AXIOM-359) OMProcessingInstructionImpl incorrectly trims the value passed in the constructor

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIOM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on AXIOM-359 started by Andreas Veithen.

> OMProcessingInstructionImpl incorrectly trims the value passed in the constructor
> ---------------------------------------------------------------------------------
>
>                 Key: AXIOM-359
>                 URL: https://issues.apache.org/jira/browse/AXIOM-359
>             Project: Axiom
>          Issue Type: Bug
>          Components: LLOM
>    Affects Versions: 1.2.11
>            Reporter: Eric Johnson
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2.12
>
>
> When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/ ), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:
>         this.value = (value == null) ? null : value.trim();
> In fact, it should do this:
>         this.value = (value == null) ? null : value;
> (That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Commented] (AXIOM-359) OMProcessingInstructionImpl incorrectly trims the value passed in the constructor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIOM-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014851#comment-13014851 ] 

Hudson commented on AXIOM-359:
------------------------------

Integrated in ws-axiom-trunk #375 (See [https://hudson.apache.org/hudson/job/ws-axiom-trunk/375/])
    

> OMProcessingInstructionImpl incorrectly trims the value passed in the constructor
> ---------------------------------------------------------------------------------
>
>                 Key: AXIOM-359
>                 URL: https://issues.apache.org/jira/browse/AXIOM-359
>             Project: Axiom
>          Issue Type: Bug
>          Components: LLOM
>    Affects Versions: 1.2.11
>            Reporter: Eric Johnson
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2.12
>
>
> When using Axiom with the Santuario port to GenXDM (https://code.google.com/a/apache-extras.org/p/santuario-genxdm/ ), we noticed that certain C14N tests failed. These tests failed because the constructor to OMProcessingInstructionImpl does:
>         this.value = (value == null) ? null : value.trim();
> In fact, it should do this:
>         this.value = (value == null) ? null : value;
> (That is, not call trim() ). Note that the "setValue()" method does not call "trim()" so the behavior is *also* inconsistent. At least the "setValue()" method appears to provide a work-around for this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org