[jira] [Commented] (DRILL-4423) TestCsvHeader#testEmptyFinalColumn is causing the unit test framework to print 10K rows in Stdout

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157669#comment-15157669 ] 

ASF GitHub Bot commented on DRILL-4423:
---------------------------------------

GitHub user adeneche opened a pull request:

    https://github.com/apache/drill/pull/387

    DRILL-4423: TestCsvHeader#testEmptyFinalColumn is causing the unit te…

    …st framework to print 10K rows in Stdout

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adeneche/incubator-drill DRILL-4423

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
    
----
commit d4f5a907957f31289733b08f01c3f9b9357a689c
Author: adeneche <ad...@gmail.com>
Date:   2016-02-22T20:48:11Z

    DRILL-4423: TestCsvHeader#testEmptyFinalColumn is causing the unit test framework to print 10K rows in Stdout

----


> TestCsvHeader#testEmptyFinalColumn is causing the unit test framework to print 10K rows in Stdout
> -------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4423
>                 URL: https://issues.apache.org/jira/browse/DRILL-4423
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>            Priority: Minor
>
> This unit test is printing 10.000 rows all equal to the following line:
> {noformat}
> field2(VARCHAR:REQUIRED)[$offsets$(UINT4:REQUIRED)]
> {noformat}
> DrillTestWrapper contains the following code in 2 separate methods that prints a field's details whenever an "empty" value is encountered:
> {code}
>             if (obj instanceof Text) {
>               obj = obj.toString();
>               if (obj.equals("")) {
>                 System.out.println(w.getField());
>               }
>             }
> {code}
> Because this particular unit test was creating 10K rows with an empty field, it was causing lot's of output to Stdout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)