[GitHub] [spark] MaxGekk commented on a diff in pull request #38569: [SPARK-41055][SQL] Rename `_LEGACY_ERROR_TEMP_2424` to `GROUP_BY_AGGREGATE`

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #38569:
URL: https://github.com/apache/spark/pull/38569#discussion_r1017615605


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -469,6 +469,11 @@
       "Grouping sets size cannot be greater than <maxSize>"
     ]
   },
+  "GROUP_BY_AGGREGATE" : {
+    "message" : [
+      "aggregate functions are not allowed in GROUP BY, but found <sqlExpr>"

Review Comment:
   The error message should begin from an upper case letter and ends with a dot. See other error messages in `error-classes.json`
   ```suggestion
         "Aggregate functions are not allowed in GROUP BY, but found <sqlExpr>."
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org