You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2018/11/23 15:00:24 UTC
[incubator-skywalking] branch mysql-style updated: Make MySQL
driver prevent test working.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch mysql-style
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/mysql-style by this push:
new 94614b4 Make MySQL driver prevent test working.
94614b4 is described below
commit 94614b42ac71155a277b96ffb1fe647334cfeedf
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Fri Nov 23 23:00:16 2018 +0800
Make MySQL driver prevent test working.
---
...er.java => PreventRedistributionMySQLDriverTest.java} | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/test/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/PreventRedistributionMySQLDriver.java b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/test/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/PreventRedistributionMySQLDriverTest.java
similarity index 73%
rename from oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/test/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/PreventRedistributionMySQLDriver.java
rename to oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/test/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/PreventRedistributionMySQLDriverTest.java
index d4f81ca..77db0fe 100644
--- a/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/test/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/PreventRedistributionMySQLDriver.java
+++ b/oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/test/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/mysql/PreventRedistributionMySQLDriverTest.java
@@ -18,7 +18,6 @@
package org.apache.skywalking.oap.server.storage.plugin.jdbc.mysql;
-import org.junit.Assert;
import org.junit.Test;
/**
@@ -29,16 +28,9 @@ import org.junit.Test;
*
* @author wusheng
*/
-public class PreventRedistributionMySQLDriver {
- @Test
- public void TestMySQLDriverNotExist() {
- boolean existDriverClassInClasspath = true;
- try {
- Class.forName("com.mysql.cj.jdbc.Driver");
- } catch (ClassNotFoundException e) {
- existDriverClassInClasspath = false;
- }
-
- Assert.assertFalse(existDriverClassInClasspath);
+public class PreventRedistributionMySQLDriverTest {
+ @Test(expected = ClassNotFoundException.class)
+ public void TestMySQLDriverNotExist() throws ClassNotFoundException {
+ Class.forName("com.mysql.cj.jdbc.Driver");
}
}