You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2016/10/26 08:22:36 UTC

[GitHub] activemq-artemis pull request #866: couple of AMQP fixes

GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/866

    couple of AMQP fixes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #866
    
----
commit 1595d0120e2b9d209b3f9addcb050c8ab2805ce2
Author: Andy Taylor <an...@gmail.com>
Date:   2016-10-26T08:06:10Z

    ARTEMIS-823 = broker doesn't settle rejected messages
    
    Currently we don't settle rejected messages at the broker, we should always settle when rejected
    
    https://issues.apache.org/jira/browse/ARTEMIS-823

commit 8d772bf99263b102f0ad20d64dea224558adb9e8
Author: Andy Taylor <an...@gmail.com>
Date:   2016-10-26T08:18:54Z

    ARTEMIS-825 - Invalid selector not handled correctly in AMQP
    
    this changes propogates the error to the client and closes the sender correctly
    
    https://issues.apache.org/jira/browse/ARTEMIS-825

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #866: couple of AMQP fixes

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/866
  
    looks good, will merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #866: couple of AMQP fixes

Posted by tabish121 <gi...@git.apache.org>.

Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/866#discussion_r85177941
  
    --- Diff: tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpSender.java ---
    @@ -71,6 +71,7 @@
     
        private final Set<Delivery> pending = new LinkedHashSet<>();
        private byte[] encodeBuffer = new byte[1024 * 8];
    +   DeliveryUpdateListener deliveryUpdateListener;
    --- End diff --
    
    I think it might make more sense to extend the validator bits already in the client to add event points for Delivery and Delivery update vs adding yet another callback mechanism.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #866: couple of AMQP fixes

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/866


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #866: couple of AMQP fixes

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/866
  
    ok i have reworked this, its good to go


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #866: couple of AMQP fixes

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/866
  
    failure looks environmental 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---