You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alan Gates <al...@gmail.com> on 2021/08/02 23:03:02 UTC
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
+1. Checked the keys and the sha checksum. Did a build and ran the
tests. Ran rat. I did get one failing test, but it doesn't look crucial:
TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]> but
was:<[???]>
Alan.
On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <ow...@gmail.com>
wrote:
> Hello all,
>
> Following on previous discussions, I would like to propose a new
> storage-api release including HIVE-25400.
>
> Shall we release the following artifacts as Hive Storage API 2.7.3?
>
> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
> tag: https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
> jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
>
> .. Owen
>
[RESULT][VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Owen O'Malley <ow...@gmail.com>.
With four +1's (3 binding) and no -1's the vote passes. I'll finalize the
release and then backport HIVE-23617 on to the release branch.
Thanks all for voting,
Owen
On Tue, Aug 3, 2021 at 4:31 PM Owen O'Malley <ow...@gmail.com> wrote:
> Alright, I tracked this down to the default java character encoding. This
> was fixed in storage api 2.8 by HIVE-23617. With the environment variable
> setting the decoding, the test case passes.
>
> export JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF-8
>
> .. Owen
>
> On Tue, Aug 3, 2021 at 12:29 AM Alan Gates <al...@gmail.com> wrote:
>
>> Centos, java-1.8.0-openjdk-devel
>>
>> Alan.
>>
>> On Mon, Aug 2, 2021 at 5:20 PM Owen O'Malley <ow...@gmail.com>
>> wrote:
>>
>> > Ok, I was able to reproduce it in ORC's Ubuntu 18 docker image. I'll
>> track
>> > it down.
>> >
>> > On Tue, Aug 3, 2021 at 12:06 AM Owen O'Malley <ow...@gmail.com>
>> > wrote:
>> >
>> > > Hmm, I just reran the build both from git and the tar ball and
>> > > TestBytesColumnVector passed both times. Which jvm were you using?
>> > >
>> > > On Tue, Aug 3, 2021 at 12:02 AM Pavan Lanka <planka@apple.com.invalid
>> >
>> > > wrote:
>> > >
>> > >> +1 (non-binding)
>> > >>
>> > >> * Built Hive Storage API (did not get the failure that Alan called
>> out)
>> > >> using the tag
>> > >> * Ran the individual test TestBytesColumnVector successfully
>> > >> * Built ORC using 2.7.3 successfully
>> > >>
>> > >> Regards,
>> > >> Pavan
>> > >>
>> > >> > On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com>
>> wrote:
>> > >> >
>> > >> > +1. Checked the keys and the sha checksum. Did a build and ran
>> the
>> > >> > tests. Ran rat. I did get one failing test, but it doesn't look
>> > >> crucial:
>> > >> >
>> > >> > TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]>
>> > but
>> > >> > was:<[???]>
>> > >> >
>> > >> > Alan.
>> > >> >
>> > >> > On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <
>> owen.omalley@gmail.com
>> > >
>> > >> > wrote:
>> > >> >
>> > >> >> Hello all,
>> > >> >>
>> > >> >> Following on previous discussions, I would like to propose a new
>> > >> >> storage-api release including HIVE-25400.
>> > >> >>
>> > >> >> Shall we release the following artifacts as Hive Storage API
>> 2.7.3?
>> > >> >>
>> > >> >> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
>> > >> >> tag:
>> > >>
>> https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
>> > >> >> jiras:
>> > https://issues.apache.org/jira/projects/HIVE/versions/12350287
>> > >> >>
>> > >> >> .. Owen
>> > >> >>
>> > >>
>> > >>
>> >
>>
>
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Owen O'Malley <ow...@gmail.com>.
Alright, I tracked this down to the default java character encoding. This
was fixed in storage api 2.8 by HIVE-23617. With the environment variable
setting the decoding, the test case passes.
export JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF-8
.. Owen
On Tue, Aug 3, 2021 at 12:29 AM Alan Gates <al...@gmail.com> wrote:
> Centos, java-1.8.0-openjdk-devel
>
> Alan.
>
> On Mon, Aug 2, 2021 at 5:20 PM Owen O'Malley <ow...@gmail.com>
> wrote:
>
> > Ok, I was able to reproduce it in ORC's Ubuntu 18 docker image. I'll
> track
> > it down.
> >
> > On Tue, Aug 3, 2021 at 12:06 AM Owen O'Malley <ow...@gmail.com>
> > wrote:
> >
> > > Hmm, I just reran the build both from git and the tar ball and
> > > TestBytesColumnVector passed both times. Which jvm were you using?
> > >
> > > On Tue, Aug 3, 2021 at 12:02 AM Pavan Lanka <pl...@apple.com.invalid>
> > > wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >> * Built Hive Storage API (did not get the failure that Alan called
> out)
> > >> using the tag
> > >> * Ran the individual test TestBytesColumnVector successfully
> > >> * Built ORC using 2.7.3 successfully
> > >>
> > >> Regards,
> > >> Pavan
> > >>
> > >> > On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com>
> wrote:
> > >> >
> > >> > +1. Checked the keys and the sha checksum. Did a build and ran the
> > >> > tests. Ran rat. I did get one failing test, but it doesn't look
> > >> crucial:
> > >> >
> > >> > TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]>
> > but
> > >> > was:<[???]>
> > >> >
> > >> > Alan.
> > >> >
> > >> > On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <
> owen.omalley@gmail.com
> > >
> > >> > wrote:
> > >> >
> > >> >> Hello all,
> > >> >>
> > >> >> Following on previous discussions, I would like to propose a new
> > >> >> storage-api release including HIVE-25400.
> > >> >>
> > >> >> Shall we release the following artifacts as Hive Storage API 2.7.3?
> > >> >>
> > >> >> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
> > >> >> tag:
> > >> https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
> > >> >> jiras:
> > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > >> >>
> > >> >> .. Owen
> > >> >>
> > >>
> > >>
> >
>
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Chao Sun <su...@apache.org>.
+1 (binding)
- build the release and ran all the tests successfully (the tests was done
in Mac OS so I didn't see the test failure Alan reported)
- verified checksum and signatures
Chao
On Mon, Aug 2, 2021 at 5:29 PM Alan Gates <al...@gmail.com> wrote:
> Centos, java-1.8.0-openjdk-devel
>
> Alan.
>
> On Mon, Aug 2, 2021 at 5:20 PM Owen O'Malley <ow...@gmail.com>
> wrote:
>
> > Ok, I was able to reproduce it in ORC's Ubuntu 18 docker image. I'll
> track
> > it down.
> >
> > On Tue, Aug 3, 2021 at 12:06 AM Owen O'Malley <ow...@gmail.com>
> > wrote:
> >
> > > Hmm, I just reran the build both from git and the tar ball and
> > > TestBytesColumnVector passed both times. Which jvm were you using?
> > >
> > > On Tue, Aug 3, 2021 at 12:02 AM Pavan Lanka <pl...@apple.com.invalid>
> > > wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >> * Built Hive Storage API (did not get the failure that Alan called
> out)
> > >> using the tag
> > >> * Ran the individual test TestBytesColumnVector successfully
> > >> * Built ORC using 2.7.3 successfully
> > >>
> > >> Regards,
> > >> Pavan
> > >>
> > >> > On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com>
> wrote:
> > >> >
> > >> > +1. Checked the keys and the sha checksum. Did a build and ran the
> > >> > tests. Ran rat. I did get one failing test, but it doesn't look
> > >> crucial:
> > >> >
> > >> > TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]>
> > but
> > >> > was:<[???]>
> > >> >
> > >> > Alan.
> > >> >
> > >> > On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <
> owen.omalley@gmail.com
> > >
> > >> > wrote:
> > >> >
> > >> >> Hello all,
> > >> >>
> > >> >> Following on previous discussions, I would like to propose a new
> > >> >> storage-api release including HIVE-25400.
> > >> >>
> > >> >> Shall we release the following artifacts as Hive Storage API 2.7.3?
> > >> >>
> > >> >> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
> > >> >> tag:
> > >> https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
> > >> >> jiras:
> > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > >> >>
> > >> >> .. Owen
> > >> >>
> > >>
> > >>
> >
>
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Alan Gates <al...@gmail.com>.
Centos, java-1.8.0-openjdk-devel
Alan.
On Mon, Aug 2, 2021 at 5:20 PM Owen O'Malley <ow...@gmail.com> wrote:
> Ok, I was able to reproduce it in ORC's Ubuntu 18 docker image. I'll track
> it down.
>
> On Tue, Aug 3, 2021 at 12:06 AM Owen O'Malley <ow...@gmail.com>
> wrote:
>
> > Hmm, I just reran the build both from git and the tar ball and
> > TestBytesColumnVector passed both times. Which jvm were you using?
> >
> > On Tue, Aug 3, 2021 at 12:02 AM Pavan Lanka <pl...@apple.com.invalid>
> > wrote:
> >
> >> +1 (non-binding)
> >>
> >> * Built Hive Storage API (did not get the failure that Alan called out)
> >> using the tag
> >> * Ran the individual test TestBytesColumnVector successfully
> >> * Built ORC using 2.7.3 successfully
> >>
> >> Regards,
> >> Pavan
> >>
> >> > On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com> wrote:
> >> >
> >> > +1. Checked the keys and the sha checksum. Did a build and ran the
> >> > tests. Ran rat. I did get one failing test, but it doesn't look
> >> crucial:
> >> >
> >> > TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]>
> but
> >> > was:<[???]>
> >> >
> >> > Alan.
> >> >
> >> > On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <owen.omalley@gmail.com
> >
> >> > wrote:
> >> >
> >> >> Hello all,
> >> >>
> >> >> Following on previous discussions, I would like to propose a new
> >> >> storage-api release including HIVE-25400.
> >> >>
> >> >> Shall we release the following artifacts as Hive Storage API 2.7.3?
> >> >>
> >> >> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
> >> >> tag:
> >> https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
> >> >> jiras:
> https://issues.apache.org/jira/projects/HIVE/versions/12350287
> >> >>
> >> >> .. Owen
> >> >>
> >>
> >>
>
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Owen O'Malley <ow...@gmail.com>.
Ok, I was able to reproduce it in ORC's Ubuntu 18 docker image. I'll track
it down.
On Tue, Aug 3, 2021 at 12:06 AM Owen O'Malley <ow...@gmail.com>
wrote:
> Hmm, I just reran the build both from git and the tar ball and
> TestBytesColumnVector passed both times. Which jvm were you using?
>
> On Tue, Aug 3, 2021 at 12:02 AM Pavan Lanka <pl...@apple.com.invalid>
> wrote:
>
>> +1 (non-binding)
>>
>> * Built Hive Storage API (did not get the failure that Alan called out)
>> using the tag
>> * Ran the individual test TestBytesColumnVector successfully
>> * Built ORC using 2.7.3 successfully
>>
>> Regards,
>> Pavan
>>
>> > On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com> wrote:
>> >
>> > +1. Checked the keys and the sha checksum. Did a build and ran the
>> > tests. Ran rat. I did get one failing test, but it doesn't look
>> crucial:
>> >
>> > TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]> but
>> > was:<[???]>
>> >
>> > Alan.
>> >
>> > On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <ow...@gmail.com>
>> > wrote:
>> >
>> >> Hello all,
>> >>
>> >> Following on previous discussions, I would like to propose a new
>> >> storage-api release including HIVE-25400.
>> >>
>> >> Shall we release the following artifacts as Hive Storage API 2.7.3?
>> >>
>> >> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
>> >> tag:
>> https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
>> >> jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
>> >>
>> >> .. Owen
>> >>
>>
>>
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Owen O'Malley <ow...@gmail.com>.
Hmm, I just reran the build both from git and the tar ball and
TestBytesColumnVector passed both times. Which jvm were you using?
On Tue, Aug 3, 2021 at 12:02 AM Pavan Lanka <pl...@apple.com.invalid>
wrote:
> +1 (non-binding)
>
> * Built Hive Storage API (did not get the failure that Alan called out)
> using the tag
> * Ran the individual test TestBytesColumnVector successfully
> * Built ORC using 2.7.3 successfully
>
> Regards,
> Pavan
>
> > On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com> wrote:
> >
> > +1. Checked the keys and the sha checksum. Did a build and ran the
> > tests. Ran rat. I did get one failing test, but it doesn't look
> crucial:
> >
> > TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]> but
> > was:<[???]>
> >
> > Alan.
> >
> > On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <ow...@gmail.com>
> > wrote:
> >
> >> Hello all,
> >>
> >> Following on previous discussions, I would like to propose a new
> >> storage-api release including HIVE-25400.
> >>
> >> Shall we release the following artifacts as Hive Storage API 2.7.3?
> >>
> >> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
> >> tag:
> https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
> >> jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
> >>
> >> .. Owen
> >>
>
>
Re: [VOTE] Should we release Hive Storage API 2.7.3-rc2?
Posted by Pavan Lanka <pl...@apple.com.INVALID>.
+1 (non-binding)
* Built Hive Storage API (did not get the failure that Alan called out) using the tag
* Ran the individual test TestBytesColumnVector successfully
* Built ORC using 2.7.3 successfully
Regards,
Pavan
> On Aug 2, 2021, at 4:03 PM, Alan Gates <al...@gmail.com> wrote:
>
> +1. Checked the keys and the sha checksum. Did a build and ran the
> tests. Ran rat. I did get one failing test, but it doesn't look crucial:
>
> TestBytesColumnVector.testConcatAndPadding:109 row 0 expected:<[?]> but
> was:<[???]>
>
> Alan.
>
> On Thu, Jul 29, 2021 at 3:14 PM Owen O'Malley <ow...@gmail.com>
> wrote:
>
>> Hello all,
>>
>> Following on previous discussions, I would like to propose a new
>> storage-api release including HIVE-25400.
>>
>> Shall we release the following artifacts as Hive Storage API 2.7.3?
>>
>> tar: http://home.apache.org/~omalley/hive-storage-2.7.3/
>> tag: https://github.com/apache/hive/releases/tag/storage-release-2.7.3-rc2
>> jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
>>
>> .. Owen
>>