You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2009/08/13 00:22:14 UTC

[jira] Created: (HBASE-1763) Put writeToWAL methods do not have proper getter/setter names

Put writeToWAL methods do not have proper getter/setter names
-------------------------------------------------------------

                 Key: HBASE-1763
                 URL: https://issues.apache.org/jira/browse/HBASE-1763
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: client
    Affects Versions: 0.20.0
            Reporter: Jonathan Gray
            Assignee: Jonathan Gray
             Fix For: 0.20.0
         Attachments: HBASE-1763-v1.patch

Put.writeToWAL() is the getter, and Put.writeToWAL(boolean) is the setter.

Should be:  Put.getWriteToWAL() returning boolean and Put.setWriteToWAL(boolean)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1763) Put writeToWAL methods do not have proper getter/setter names

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1763:
---------------------------------

    Status: Patch Available  (was: Open)

Simple patch, please review.

> Put writeToWAL methods do not have proper getter/setter names
> -------------------------------------------------------------
>
>                 Key: HBASE-1763
>                 URL: https://issues.apache.org/jira/browse/HBASE-1763
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1763-v1.patch
>
>
> Put.writeToWAL() is the getter, and Put.writeToWAL(boolean) is the setter.
> Should be:  Put.getWriteToWAL() returning boolean and Put.setWriteToWAL(boolean)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1763) Put writeToWAL methods do not have proper getter/setter names

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1763:
---------------------------------

    Attachment: HBASE-1763-v1.patch

> Put writeToWAL methods do not have proper getter/setter names
> -------------------------------------------------------------
>
>                 Key: HBASE-1763
>                 URL: https://issues.apache.org/jira/browse/HBASE-1763
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1763-v1.patch
>
>
> Put.writeToWAL() is the getter, and Put.writeToWAL(boolean) is the setter.
> Should be:  Put.getWriteToWAL() returning boolean and Put.setWriteToWAL(boolean)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1763) Put writeToWAL methods do not have proper getter/setter names

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742615#action_12742615 ] 

stack commented on HBASE-1763:
------------------------------

+1

Please backport.

> Put writeToWAL methods do not have proper getter/setter names
> -------------------------------------------------------------
>
>                 Key: HBASE-1763
>                 URL: https://issues.apache.org/jira/browse/HBASE-1763
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1763-v1.patch
>
>
> Put.writeToWAL() is the getter, and Put.writeToWAL(boolean) is the setter.
> Should be:  Put.getWriteToWAL() returning boolean and Put.setWriteToWAL(boolean)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1763) Put writeToWAL methods do not have proper getter/setter names

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1763:
---------------------------------

    Attachment: HBASE-1763-v1fix.patch

Broke trunk and branch.  Patch fixes.

> Put writeToWAL methods do not have proper getter/setter names
> -------------------------------------------------------------
>
>                 Key: HBASE-1763
>                 URL: https://issues.apache.org/jira/browse/HBASE-1763
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0, 0.21.0
>
>         Attachments: HBASE-1763-v1.patch, HBASE-1763-v1fix.patch
>
>
> Put.writeToWAL() is the getter, and Put.writeToWAL(boolean) is the setter.
> Should be:  Put.getWriteToWAL() returning boolean and Put.setWriteToWAL(boolean)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1763) Put writeToWAL methods do not have proper getter/setter names

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1763:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed to trunk and branch.  Thanks for review.

> Put writeToWAL methods do not have proper getter/setter names
> -------------------------------------------------------------
>
>                 Key: HBASE-1763
>                 URL: https://issues.apache.org/jira/browse/HBASE-1763
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0, 0.21.0
>
>         Attachments: HBASE-1763-v1.patch
>
>
> Put.writeToWAL() is the getter, and Put.writeToWAL(boolean) is the setter.
> Should be:  Put.getWriteToWAL() returning boolean and Put.setWriteToWAL(boolean)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.