You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/05 17:24:55 UTC

[GitHub] [nifi] mtien-apache commented on a change in pull request #4788: NIFI-8132 Replaced framework uses of MD5 with SHA-256

mtien-apache commented on a change in pull request #4788:
URL: https://github.com/apache/nifi/pull/4788#discussion_r571126078



##########
File path: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/FileUtils.java
##########
@@ -549,49 +548,22 @@ public static void syncWithRestore(final File primaryFile, final File restoreFil
      * @throws IOException if the MD5 hash could not be computed

Review comment:
       @exceptionfactory Suggestion to change the name to the hashing algorithm being used. Same for above description.
   ```suggestion
        * @throws IOException if the SHA-256 hash could not be computed
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org