[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #2392: LUCENE-9705: Create Lucene90DocValuesFormat and Lucene90NormsFormat

[GitBox <gi...@apache.org>]

jtibshirani commented on a change in pull request #2392:
URL: https://github.com/apache/lucene-solr/pull/2392#discussion_r580481448



##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene80/Lucene80DocValuesFormat.java
##########
@@ -163,6 +163,11 @@ public Lucene80DocValuesFormat(Mode mode) {
     this.mode = Objects.requireNonNull(mode);
   }
 
+  /**
+   * Note: although this format is only used on older versions, we need to keep the write logic in
+   * addition to the read logic. It's possible for doc values on older segments to be written to
+   * through in-place doc values updates.

Review comment:
       Agreed, in-place can mean too many things...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org