You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/04/11 16:29:39 UTC
Review Request 58357: Added more language support in test-upgrade
script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This patch added support to java and python based test framework in
`test-upgrade.py` script by adding a new option `--lang`.
Diffs
-----
3rdparty/cmake/cotire.cmake ab611007dc4e5ed872a629b99b5cde659c8eb7f2
3rdparty/libprocess/include/process/dispatch.hpp 3a0793888dc0df5e3ec31b06f47cd920c71e0db9
3rdparty/libprocess/include/process/future.hpp cce950509f58022e79bb51a6e72ea1a005b9cb50
3rdparty/libprocess/include/process/http.hpp 5c013ca4311acc22dcb1096aadee984a27be8d95
3rdparty/libprocess/include/process/socket.hpp 42287c128fb352af6a196b7abc77f913a2ddbba0
3rdparty/libprocess/include/process/timer.hpp 6df57f4203213b49bebd85dd95f9a2a01d925c25
3rdparty/libprocess/include/process/windows/jobobject.hpp 5fb41c41b3f6242ed04a3274b9a3f27f705db26e
3rdparty/libprocess/include/process/windows/subprocess.hpp 5459955fb3b7b07b976ece61bf59bc237896e2de
3rdparty/libprocess/src/http.cpp 9789607933745f1fc4e37f47ce1be6aecb33a6e6
3rdparty/libprocess/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba
3rdparty/libprocess/src/process.cpp d0cba0c2299bddfedeb8bfde5b93aae733a9cd5b
3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d
3rdparty/libprocess/src/subprocess_windows.cpp cc71fbd7a43c88a24602540cd65e2073473ddb2c
3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
3rdparty/stout/include/stout/check.hpp e3cabd413a37be536361b450dc857a725130fde3
3rdparty/stout/include/stout/elf.hpp ba3fad924a95ea00c92da576df1d7f0533938dd7
3rdparty/stout/include/stout/gtest.hpp a004a378cb467495234d77a0c56fbea6e7bec420
3rdparty/stout/include/stout/os/posix/killtree.hpp 9f18a48b94ddcbc4b3881ff4ab94c777bb10028d
3rdparty/stout/include/stout/os/posix/socket.hpp 927e7a1a6a93e4b99e4a67bac1977ec6d0d9e6a1
3rdparty/stout/include/stout/os/posix/stat.hpp 2762c41fdebc28c412126e39029cd03345677a73
3rdparty/stout/include/stout/os/raw/environment.hpp c7f889f0caa78d9f82dc9337f2bcf205d5a0174a
3rdparty/stout/include/stout/os/stat.hpp d002c98ac3afbcdc8886a8ba6657919d011f2b46
3rdparty/stout/include/stout/os/windows/killtree.hpp 267a9a0db6c5e077f0da617c572884ea86b26932
3rdparty/stout/include/stout/os/windows/shell.hpp b93f33771302ebbb1ce0c8515a3101a33f9956f5
3rdparty/stout/include/stout/os/windows/socket.hpp 43f5436c375549406af6254f9d3f9ded29f61914
3rdparty/stout/include/stout/os/windows/stat.hpp b2ff43696a6b4172a2ebcf08ae36aa9e143ad101
3rdparty/stout/include/stout/stringify.hpp 698431583d2288d3c635211e651914316bfd3ee9
3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae
CHANGELOG 289069b39cb96c57c7603649a04c500fe84d0844
CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f
LICENSE 512b089c5dd2540f9f83afb559e5d0998d97ea22
cmake/CompilationConfigure.cmake 1c5466960f5ac73b8fc81edf7950cc68ed744301
docs/authentication.md 279e00a513d386eb6215a4e6d66652a0af3ec56d
docs/authorization.md 913765f979645356395ac7bb1d13f77d0c3bd00b
docs/committers.md 5eae1be88414a0970eed20cb7904d6213e2d926d
docs/configuration.md 452478eab36f352a31f62f0c1f4da2f43f89bef9
docs/container-image.md fad4fd22533de960c2c5cfc52ae7d13a9cffdc67
docs/containerizer-internals.md a2eb9c05992bdeafdad7c002462fb4119bfcb6b3
docs/containerizer.md b6cf55bcaca8704443078b56a7e002ea1f535bd5
docs/contributors.yaml 41afddb0ec3c5a62886de0ec5dffe91c41902690
docs/design-docs.md 2ea649631063707042444060361cec1ef0199f53
docs/executor-http-api.md c49c234d73ece925297051b8d07fbe48e47868e0
docs/getting-started.md 2578a291e242e21caea0ef24f8fff820d9428f76
docs/home.md 40061ea64fdb9438bd66e6c89d1e3099eac52388
docs/markdown-style-guide.md ac40387227f3872fcff6588dfa992ee688f20cb9
docs/modules.md 9e19774a3afa3020164d6ecf69a760419e00181c
docs/nested-container-and-task-group.md 7f89c26adc0faa2759c06c47a92f6853634d5508
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/operator-http-api.md 8a2a0ae31adb5075e0ec1bc9c8a4563840682b82
docs/oversubscription.md e4a1baede722c7958a6c05af2cf82a0e970b35e0
docs/persistent-volume.md bd2f5391e0e6df5155b2c5644eddb3ca861108e9
docs/quota.md f36ab1a22a7858c8b28a13f94a37728d6f56c5e1
docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
docs/replicated-log-internals.md 66497ccd7298103819501fbc3a800db437ca37d5
docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
docs/roles.md 33452ec4361fbe55d2d18393c98953c3d2a19726
docs/scheduler-http-api.md 4a5d77b88ae7cf0a0d8d39fe2579eb68bf33059a
docs/shared-resources.md 2643c2854f9981a4351aaa1b31aa6f6c9c2b9926
docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
docs/upgrades.md a12e6ea376c5b7d51f09b532336e53326b35f0de
docs/versioning.md 3ad12492b779c07edda600af1f691dd439f69569
docs/working-groups.md b6a0b358a340658849e25646f5174e4c299734ff
include/mesos/authentication/secret_generator.hpp 680b0d675d339812b86e683485fa2f3af6f6dda2
include/mesos/authorizer/acls.proto ae10027eb716d4dcdeddf924223bcd4faed36de9
include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/module/secret_generator.hpp 2add6b829bc4bfc58bebd42909376d3fe9423e82
include/mesos/oci/spec.hpp d8eef84b5770608c359285d9168f7ea5de4eba12
include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d
include/mesos/resource_provider/resource_provider.hpp 039c7c2f76976a19a09dce7f57ba72c740fb14fa
include/mesos/resource_provider/resource_provider.proto 73cfd31a68fb34da91c5d8df7aee8d8860aff3bd
include/mesos/type_utils.hpp 2cfbe1065daec1e23ae405db1c6b12178aa5ed9f
include/mesos/v1/mesos.hpp e665ce7046eb6e9c4f0e896e4f8cf9e976c40454
include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
include/mesos/v1/resource_provider/resource_provider.hpp 2b8c8afab852621fb49b132813d512d0c96bc68c
include/mesos/v1/resource_provider/resource_provider.proto f83586d3ae3e1e48b3384b7961018682db942efb
site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c
site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac
site/source/blog/2017-03-14-mesos-1-1-1-released.md c7fd8469313bb93b5228c9771cdaffbcc87f459d
src/CMakeLists.txt 89cbd3f5a93f4891e8272d3b1136059ab1069d01
src/Makefile.am 1fc453c497f278c9fc3fa5e91eb720a932915fde
src/authentication/executor/jwt_secret_generator.hpp 91c0d86c43d79d47431cec287cee95b3e9e0eae7
src/authentication/executor/jwt_secret_generator.cpp 1d7c010a111c8dfcb574e8044694d670b641cf33
src/authentication/http/combined_authenticator.cpp 51ec8829cd3323f23389537d5fce4850ffcfc0e9
src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11
src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6
src/checks/health_checker.hpp e17f12f75d388443f6592455177f5bdae31b7c0f
src/checks/health_checker.cpp 769278c40b5e505dc49a49a23d8c0dd97f201a53
src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a
src/common/build.cpp 4192b89cbee1c9d7a75213f55b189565cd8a10f1
src/common/command_utils.cpp d5f0dff29be830bb37b2c383c1318e268da370bb
src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e
src/common/http.cpp 92f063652691a5e1932728d2314c1241c8841109
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298
src/docker/docker.cpp 3b934d922ec01fdc9b76681bf937f7a435224688
src/docker/executor.hpp a4a8ec9905d3c6b3afcf0e2ba4e174c41fbcd75a
src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
src/examples/java/V1TestFramework.java d8bd5cfa539a614413317935e38365b5f7b648b5
src/executor/executor.cpp 9c14054f2bb08c1041138fb297d29ff6fd807792
src/files/files.cpp b03279ee0b23b3a33383c6d3e0c31faa97dab8eb
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
src/internal/evolve.cpp 93196f301e820b99572ee008b98a124ddafe9697
src/launcher/CMakeLists.txt 8b5ffe8a3702681b80ca0e0af609d7a31be5cf0e
src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299
src/launcher/executor.cpp d14fbfb65d1cc44c954c8cdbbf36d7ddf6ede19e
src/launcher/posix/executor.cpp PRE-CREATION
src/launcher/windows/executor.cpp PRE-CREATION
src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
src/linux/fs.hpp cbc8bf79083ce2bc34fa698808eaf92764a577a9
src/linux/ldcache.cpp e93334465911d3ec37f38d51249486d5d317bdb3
src/linux/perf.cpp 5f4f50aa26c5142a3a079ea1103e55e3de96ac30
src/linux/routing/filter/internal.hpp b22a818517e98fecf5ddf96fd0fa2ed95ecde15d
src/master/allocator/mesos/hierarchical.cpp ff9e2340e88f50f02aa8ebfd6b6ce039f347bb5d
src/master/flags.hpp 9336a50d657af319ec8f144a8283e09d8505344f
src/master/flags.cpp b5660e4775c17a773c85491d63ec18777577404a
src/master/http.cpp 0b3c5013550ba7587b467723e2f7c1e70d6a3ce2
src/master/main.cpp 90d159e248924f6806271dda1ced6d37dfa5f5c9
src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034
src/master/master.cpp e547d2c410471f42bfeaae40a8b57ca30033e54f
src/master/quota_handler.cpp 7ff43a048e17b9e9ac0ceed248f7b3fd56b007d6
src/oci/spec.cpp 6cb3255883779fafd657fc9313113d7d209b96f8
src/slave/constants.hpp ef978d6edf1708902dd5da0768d0c5cb80df9d19
src/slave/container_loggers/lib_logrotate.cpp bc13e6a52460d4607873c4b0022165038051bc51
src/slave/containerizer/composing.cpp 0b6c76b3d081d86df81a6062ae7a191ba8dadfde
src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f
src/slave/containerizer/fetcher.cpp a910fea5a5556afb376524c5bb2ff98d7d84e611
src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 65c1e47a569f320b63b54e5f4fc1da374d02ee0d
src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp fc763bd7834567882146ad25e0266b1183154dc3
src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 18a8066b064835cbd7a2cef6d1a43462bdd5e87c
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d03c14c0834589345eb15db61e67854f3c606637
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp ce795628f19f0e8138ad9a0b50b7d644b9d734a8
src/slave/containerizer/mesos/isolators/posix.hpp caa282c95746e845992c971982892cf60c9b982c
src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
src/slave/containerizer/mesos/launch.cpp 2835beff9dbfa7f2a1cac306a58e2b1d66c14342
src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
src/slave/containerizer/mesos/launcher.cpp ec31fa24c8b91583b8b327a0c658ed6e87bd292f
src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
src/slave/containerizer/mesos/mount.hpp 038426d57e91e0570003b8c313efc3f6bbb0cd47
src/slave/containerizer/mesos/provisioner/provisioner.cpp be45fc59027f176b43b767e9441fd8089ceec7b4
src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265
src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe
src/slave/http.cpp b07ce7c73a90ef297d980806ebba9530d86f25ae
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
src/slave/paths.hpp 51b481fc0870f1e95448f85ee2fd485fceea1919
src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
src/slave/slave.hpp b26bdf85ec055b5f55a8176d9533000a209fea7c
src/slave/slave.cpp f013e9c7d1c089ec72e2e5db986fd52423ebb8fe
src/slave/state.cpp 33dcc7a148f9a6b1a3216cce45710da8fd819ba6
src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43
src/slave/windows_ctrlhandler.hpp 145a232bcc8428224ac235864845ab91615ca587
src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d
src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422
src/tests/cluster.cpp 02590a27aadd0583177f21a57ec3d05fe1542f42
src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
src/tests/containerizer/docker_containerizer_tests.cpp 4eef399b05f6e35d75c7c23992f0ccda04576277
src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
src/tests/containerizer/mesos_containerizer_tests.cpp 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4
src/tests/containerizer/oci_spec_tests.cpp 011e6d0f492c186b3beb3415b0879a5fe7889189
src/tests/containerizer/provisioner_appc_tests.cpp cba83c6f18f6aa720497a8bc80360900a12e43fe
src/tests/containerizer/provisioner_docker_tests.cpp dbbc3533ae269c31c98017d98888d5748ef6e1ce
src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33
src/tests/executor_http_api_tests.cpp 910dbbfc7cf0d2613b4faeacb77e758a4243a4fb
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/flags.hpp 664782d03b8d6d9097a45a6f46fb42ec54ab4fe7
src/tests/health_check_tests.cpp c5857b2415faaec4d0557e50cbeb42379f4550ac
src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
src/tests/http_authentication_tests.cpp 99bc257435897f71711329442388ff8e577976c1
src/tests/http_fault_tolerance_tests.cpp 8fcd56d86dcbdd181864756187beb4ff2ac1ff2a
src/tests/master_quota_tests.cpp 1714ba13ea63bae05448d0898bf722ef472c672b
src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
src/tests/mock_slave.hpp 2b30b87db14981909dd44518e06d96f71824c87c
src/tests/mock_slave.cpp 35cd13dbf2848ab4583b5ba21c46b01a17c3e35d
src/tests/partition_tests.cpp 4ff428564d1fa6cb96e6f8ec8edc331da88a3eb6
src/tests/reservation_endpoints_tests.cpp cc8499a5ec05cf7b2283c075e47298918f50bd24
src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
src/tests/role_tests.cpp 0433c0599eac5f4648bc0dfe3a0fa8d5f7a836ca
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
src/tests/secret_generator_tests.cpp 7fd649b2bb403d943955b5df1299c5c58b2c7582
src/tests/slave_recovery_tests.cpp 53f33a2b0411c8158326074ce043c7b1dbeef5b4
src/tests/slave_tests.cpp cd769687e0f161512c0114ef4651508c31f51639
src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a
src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8
src/uri/fetchers/docker.cpp d6d2e8e72554c5f96c3875af8ef93e0bc2107af6
src/v1/mesos.cpp 9c7d6410d3f3e2b93054a77323650c59904ab90e
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
src/webui/master/static/agent_framework.html 06f1697aac91c70f5c0350159ffd26958a8436f1
src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
support/mesos-tidy.sh 875108ae18c583e24411264983433b902b43412c
support/post-reviews.py 410fb3371a3c46adbfd68c7584ffd6cf3b3010d1
support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/1/
Testing
-------
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
Re: Review Request 58357: Added more language support in test-upgrade
script.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 18, 2017, 5:20 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 76-85 (patched)
> > <https://reviews.apache.org/r/58357/diff/2/?file=1689457#file1689457line78>
> >
> > A high level comment: insteads of parametrizing the framework by "language", perhaps we could parametrize it by something more generic like "framework name". You could use names like "cpp-test-framework", etc. This would make it easier to expand this list to include other test frameworks from the codebase in the future. What do you think?
>
> Zhitao Li wrote:
> Sounds good. I'll go with this list in the diff:
>
> - `cpp-test-framework`,
> - `java-test-framework`,
> - `python-test-framework`
>
> and we can add more in the future. How does this plan sound?
Sounds good
> On April 18, 2017, 5:20 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 164 (patched)
> > <https://reviews.apache.org/r/58357/diff/2/?file=1689457#file1689457line166>
> >
> > Perhaps the default should be to run all of the available test frameworks, rather than just one?
>
> Zhitao Li wrote:
> My only concern here is that certain frameworks are more flaky and subjective to environments broken. For example, both python and java based test frameworks have been broken from time to time in either my MacOS or Linux environment (which might be different from the author's).
>
> As long as the expectation is that user will look into why things are broken, I'm fine changing this to run all by default, and change the flag to "exclude some frameworks by name".
Yea, fair point. I'd say let's err on the side of caution and run them all by default - this will help expose broken test frameworks and push us to fix them more quickly.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172226
-----------------------------------------------------------
On April 12, 2017, 12:02 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:02 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script by adding a new option `--lang`.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/2/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Added more language support in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
> On April 18, 2017, 5:20 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 164 (patched)
> > <https://reviews.apache.org/r/58357/diff/2/?file=1689457#file1689457line166>
> >
> > Perhaps the default should be to run all of the available test frameworks, rather than just one?
My only concern here is that certain frameworks are more flaky and subjective to environments broken. For example, both python and java based test frameworks have been broken from time to time in either my MacOS or Linux environment (which might be different from the author's).
As long as the expectation is that user will look into why things are broken, I'm fine changing this to run all by default, and change the flag to "exclude some frameworks by name".
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172226
-----------------------------------------------------------
On April 12, 2017, 12:02 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:02 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script by adding a new option `--lang`.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/2/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Added more language support in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
> On April 18, 2017, 5:20 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 76-85 (patched)
> > <https://reviews.apache.org/r/58357/diff/2/?file=1689457#file1689457line78>
> >
> > A high level comment: insteads of parametrizing the framework by "language", perhaps we could parametrize it by something more generic like "framework name". You could use names like "cpp-test-framework", etc. This would make it easier to expand this list to include other test frameworks from the codebase in the future. What do you think?
Sounds good. I'll go with this list in the diff:
- `cpp-test-framework`,
- `java-test-framework`,
- `python-test-framework`
and we can add more in the future. How does this plan sound?
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172226
-----------------------------------------------------------
On April 12, 2017, 12:02 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:02 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script by adding a new option `--lang`.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/2/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Added more language support in test-upgrade
script.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172226
-----------------------------------------------------------
Thanks for this, Zhitao! Glad to see this script getting some new functionality. :)
support/test-upgrade.py
Lines 76-85 (patched)
<https://reviews.apache.org/r/58357/#comment245329>
A high level comment: insteads of parametrizing the framework by "language", perhaps we could parametrize it by something more generic like "framework name". You could use names like "cpp-test-framework", etc. This would make it easier to expand this list to include other test frameworks from the codebase in the future. What do you think?
support/test-upgrade.py
Lines 164 (patched)
<https://reviews.apache.org/r/58357/#comment245331>
Perhaps the default should be to run all of the available test frameworks, rather than just one?
- Greg Mann
On April 12, 2017, 12:02 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 12:02 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script by adding a new option `--lang`.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/2/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173277
-----------------------------------------------------------
Fix it, then Ship it!
support/test-upgrade.py
Lines 342-343 (patched)
<https://reviews.apache.org/r/58357/#comment246314>
Could you add an extra newline (or two?) at the end of this print statement? Currently, the output in between interations has no newline separating one run from the next:
```
Test case 4 (Run of next setup)
##### Starting mesos 1.3.0 cpp-test-framework #####
Waiting for mesos 1.3.0 cpp-test-framework to complete (10 sec max)...
Run ['/mnt/src/mesos/build/src/test-framework', '--master=127.0.0.1:5050'], output: /tmp/tmpMNDhg3
mesos 1.3.0 cpp-test-framework succeeded with mesos 1.3.0 master and mesos 1.3.0 agent
Upgrade test succeeded for framework cpp-test-framework from mesos 1.2.0 to mesos 1.3.0
Running upgrade test from mesos 1.2.0 to mesos 1.3.0 for framework java-test-framework
+--------------+----------------+----------------+---------------+
| Test case | Framework | Master | Agent |
+--------------+----------------+----------------+---------------+
| #1 | mesos 1.2.0 | mesos 1.2.0 | mesos 1.2.0 |
| #2 | mesos 1.2.0 | mesos 1.3.0 | mesos 1.2.0 |
| #3 | mesos 1.2.0 | mesos 1.3.0 | mesos 1.3.0 |
| #4 | mesos 1.3.0 | mesos 1.3.0 | mesos 1.3.0 |
+--------------+----------------+----------------+---------------+
NOTE: live denotes that master process keeps running from previous case.
```
- Greg Mann
On April 27, 2017, 5:58 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:58 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/4/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173303
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58357]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 27, 2017, 5:58 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:58 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/4/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review173424
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58357]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 29, 2017, 12:17 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 12:17 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/5/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
-----------------------------------------------------------
(Updated April 29, 2017, 12:17 a.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
This patch added support to java and python based test framework in
`test-upgrade.py` script.
Diffs (updated)
-----
support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/5/
Changes: https://reviews.apache.org/r/58357/diff/4-5/
Testing
-------
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
-----------------------------------------------------------
(Updated April 27, 2017, 5:58 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
This patch added support to java and python based test framework in
`test-upgrade.py` script.
Diffs (updated)
-----
support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/4/
Changes: https://reviews.apache.org/r/58357/diff/3-4/
Testing
-------
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
> On April 20, 2017, 9:40 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 298-302 (patched)
> > <https://reviews.apache.org/r/58357/diff/3/?file=1694387#file1694387line326>
> >
> > Would it be possible to allow the user to exclude more than one at a time? I would also be find with the user specifying explicitly a list of the frameworks they _do_ want to run.
Yes I can make this a comma separated list.
Do you think we need both of `excluding tests` and `only run tests`?
> On April 20, 2017, 9:40 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 325-326 (patched)
> > <https://reviews.apache.org/r/58357/diff/3/?file=1694387#file1694387line353>
> >
> > Could you add an extra newline or two of logging at the end of each iteration? It's a bit hard to read the logging output since there are no newlines between the end of each framework run.
Will do.
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
-----------------------------------------------------------
On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 4:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/3/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 20, 2017, 9:40 p.m., Greg Mann wrote:
> > support/test-upgrade.py
> > Lines 298-302 (patched)
> > <https://reviews.apache.org/r/58357/diff/3/?file=1694387#file1694387line326>
> >
> > Would it be possible to allow the user to exclude more than one at a time? I would also be find with the user specifying explicitly a list of the frameworks they _do_ want to run.
>
> Zhitao Li wrote:
> Yes I can make this a comma separated list.
>
> Do you think we need both of `excluding tests` and `only run tests`?
I think just one or the other is fine.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
-----------------------------------------------------------
On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 4:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/3/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
-----------------------------------------------------------
Tested this out; works great!! Just a couple small things below.
support/test-upgrade.py
Lines 298-302 (patched)
<https://reviews.apache.org/r/58357/#comment245652>
Would it be possible to allow the user to exclude more than one at a time? I would also be find with the user specifying explicitly a list of the frameworks they _do_ want to run.
support/test-upgrade.py
Lines 325-326 (patched)
<https://reviews.apache.org/r/58357/#comment245653>
Could you add an extra newline or two of logging at the end of each iteration? It's a bit hard to read the logging output since there are no newlines between the end of each framework run.
- Greg Mann
On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 4:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/3/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172403
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58357]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 4:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/58357/diff/3/
>
>
> Testing
> -------
>
> Ran this on all three languages options for cpp, java and python.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58357: Support more test frameworks in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
-----------------------------------------------------------
(Updated April 19, 2017, 4:28 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
Changes
-------
Greg's review comments.
Summary (updated)
-----------------
Support more test frameworks in test-upgrade script.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description (updated)
-------
This patch added support to java and python based test framework in
`test-upgrade.py` script.
Diffs (updated)
-----
support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/3/
Changes: https://reviews.apache.org/r/58357/diff/2-3/
Testing
-------
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
Re: Review Request 58357: Added more language support in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
-----------------------------------------------------------
(Updated April 12, 2017, 12:02 a.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
Changes
-------
Rebase.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
This patch added support to java and python based test framework in
`test-upgrade.py` script by adding a new option `--lang`.
Diffs (updated)
-----
support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/2/
Changes: https://reviews.apache.org/r/58357/diff/1-2/
Testing
-------
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
Re: Review Request 58357: Added more language support in test-upgrade
script.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/
-----------------------------------------------------------
(Updated April 11, 2017, 4:30 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
This patch added support to java and python based test framework in
`test-upgrade.py` script by adding a new option `--lang`.
Diffs
-----
3rdparty/cmake/cotire.cmake ab611007dc4e5ed872a629b99b5cde659c8eb7f2
3rdparty/libprocess/include/process/dispatch.hpp 3a0793888dc0df5e3ec31b06f47cd920c71e0db9
3rdparty/libprocess/include/process/future.hpp cce950509f58022e79bb51a6e72ea1a005b9cb50
3rdparty/libprocess/include/process/http.hpp 5c013ca4311acc22dcb1096aadee984a27be8d95
3rdparty/libprocess/include/process/socket.hpp 42287c128fb352af6a196b7abc77f913a2ddbba0
3rdparty/libprocess/include/process/timer.hpp 6df57f4203213b49bebd85dd95f9a2a01d925c25
3rdparty/libprocess/include/process/windows/jobobject.hpp 5fb41c41b3f6242ed04a3274b9a3f27f705db26e
3rdparty/libprocess/include/process/windows/subprocess.hpp 5459955fb3b7b07b976ece61bf59bc237896e2de
3rdparty/libprocess/src/http.cpp 9789607933745f1fc4e37f47ce1be6aecb33a6e6
3rdparty/libprocess/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba
3rdparty/libprocess/src/process.cpp d0cba0c2299bddfedeb8bfde5b93aae733a9cd5b
3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d
3rdparty/libprocess/src/subprocess_windows.cpp cc71fbd7a43c88a24602540cd65e2073473ddb2c
3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd
3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115
3rdparty/stout/include/stout/check.hpp e3cabd413a37be536361b450dc857a725130fde3
3rdparty/stout/include/stout/elf.hpp ba3fad924a95ea00c92da576df1d7f0533938dd7
3rdparty/stout/include/stout/gtest.hpp a004a378cb467495234d77a0c56fbea6e7bec420
3rdparty/stout/include/stout/os/posix/killtree.hpp 9f18a48b94ddcbc4b3881ff4ab94c777bb10028d
3rdparty/stout/include/stout/os/posix/socket.hpp 927e7a1a6a93e4b99e4a67bac1977ec6d0d9e6a1
3rdparty/stout/include/stout/os/posix/stat.hpp 2762c41fdebc28c412126e39029cd03345677a73
3rdparty/stout/include/stout/os/raw/environment.hpp c7f889f0caa78d9f82dc9337f2bcf205d5a0174a
3rdparty/stout/include/stout/os/stat.hpp d002c98ac3afbcdc8886a8ba6657919d011f2b46
3rdparty/stout/include/stout/os/windows/killtree.hpp 267a9a0db6c5e077f0da617c572884ea86b26932
3rdparty/stout/include/stout/os/windows/shell.hpp b93f33771302ebbb1ce0c8515a3101a33f9956f5
3rdparty/stout/include/stout/os/windows/socket.hpp 43f5436c375549406af6254f9d3f9ded29f61914
3rdparty/stout/include/stout/os/windows/stat.hpp b2ff43696a6b4172a2ebcf08ae36aa9e143ad101
3rdparty/stout/include/stout/stringify.hpp 698431583d2288d3c635211e651914316bfd3ee9
3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae
CHANGELOG 289069b39cb96c57c7603649a04c500fe84d0844
CMakeLists.txt ea529ec2d5c2b9be4f19c67c2033c3f4b9073c1f
LICENSE 512b089c5dd2540f9f83afb559e5d0998d97ea22
cmake/CompilationConfigure.cmake 1c5466960f5ac73b8fc81edf7950cc68ed744301
docs/authentication.md 279e00a513d386eb6215a4e6d66652a0af3ec56d
docs/authorization.md 913765f979645356395ac7bb1d13f77d0c3bd00b
docs/committers.md 5eae1be88414a0970eed20cb7904d6213e2d926d
docs/configuration.md 452478eab36f352a31f62f0c1f4da2f43f89bef9
docs/container-image.md fad4fd22533de960c2c5cfc52ae7d13a9cffdc67
docs/containerizer-internals.md a2eb9c05992bdeafdad7c002462fb4119bfcb6b3
docs/containerizer.md b6cf55bcaca8704443078b56a7e002ea1f535bd5
docs/contributors.yaml 41afddb0ec3c5a62886de0ec5dffe91c41902690
docs/design-docs.md 2ea649631063707042444060361cec1ef0199f53
docs/executor-http-api.md c49c234d73ece925297051b8d07fbe48e47868e0
docs/getting-started.md 2578a291e242e21caea0ef24f8fff820d9428f76
docs/home.md 40061ea64fdb9438bd66e6c89d1e3099eac52388
docs/markdown-style-guide.md ac40387227f3872fcff6588dfa992ee688f20cb9
docs/modules.md 9e19774a3afa3020164d6ecf69a760419e00181c
docs/nested-container-and-task-group.md 7f89c26adc0faa2759c06c47a92f6853634d5508
docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff
docs/operator-http-api.md 8a2a0ae31adb5075e0ec1bc9c8a4563840682b82
docs/oversubscription.md e4a1baede722c7958a6c05af2cf82a0e970b35e0
docs/persistent-volume.md bd2f5391e0e6df5155b2c5644eddb3ca861108e9
docs/quota.md f36ab1a22a7858c8b28a13f94a37728d6f56c5e1
docs/release-guide.md fa607287456dff5e078fe97690ef3728a6419e8a
docs/replicated-log-internals.md 66497ccd7298103819501fbc3a800db437ca37d5
docs/reservation.md 3a42783deb5b8ad288e626612c196bfd8439d299
docs/roles.md 33452ec4361fbe55d2d18393c98953c3d2a19726
docs/scheduler-http-api.md 4a5d77b88ae7cf0a0d8d39fe2579eb68bf33059a
docs/shared-resources.md 2643c2854f9981a4351aaa1b31aa6f6c9c2b9926
docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
docs/upgrades.md a12e6ea376c5b7d51f09b532336e53326b35f0de
docs/versioning.md 3ad12492b779c07edda600af1f691dd439f69569
docs/working-groups.md b6a0b358a340658849e25646f5174e4c299734ff
include/mesos/authentication/secret_generator.hpp 680b0d675d339812b86e683485fa2f3af6f6dda2
include/mesos/authorizer/acls.proto ae10027eb716d4dcdeddf924223bcd4faed36de9
include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/module/secret_generator.hpp 2add6b829bc4bfc58bebd42909376d3fe9423e82
include/mesos/oci/spec.hpp d8eef84b5770608c359285d9168f7ea5de4eba12
include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d
include/mesos/resource_provider/resource_provider.hpp 039c7c2f76976a19a09dce7f57ba72c740fb14fa
include/mesos/resource_provider/resource_provider.proto 73cfd31a68fb34da91c5d8df7aee8d8860aff3bd
include/mesos/type_utils.hpp 2cfbe1065daec1e23ae405db1c6b12178aa5ed9f
include/mesos/v1/mesos.hpp e665ce7046eb6e9c4f0e896e4f8cf9e976c40454
include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
include/mesos/v1/resource_provider/resource_provider.hpp 2b8c8afab852621fb49b132813d512d0c96bc68c
include/mesos/v1/resource_provider/resource_provider.proto f83586d3ae3e1e48b3384b7961018682db942efb
site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c
site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac
site/source/blog/2017-03-14-mesos-1-1-1-released.md c7fd8469313bb93b5228c9771cdaffbcc87f459d
src/CMakeLists.txt 89cbd3f5a93f4891e8272d3b1136059ab1069d01
src/Makefile.am 1fc453c497f278c9fc3fa5e91eb720a932915fde
src/authentication/executor/jwt_secret_generator.hpp 91c0d86c43d79d47431cec287cee95b3e9e0eae7
src/authentication/executor/jwt_secret_generator.cpp 1d7c010a111c8dfcb574e8044694d670b641cf33
src/authentication/http/combined_authenticator.cpp 51ec8829cd3323f23389537d5fce4850ffcfc0e9
src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc
src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11
src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6
src/checks/health_checker.hpp e17f12f75d388443f6592455177f5bdae31b7c0f
src/checks/health_checker.cpp 769278c40b5e505dc49a49a23d8c0dd97f201a53
src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a
src/common/build.cpp 4192b89cbee1c9d7a75213f55b189565cd8a10f1
src/common/command_utils.cpp d5f0dff29be830bb37b2c383c1318e268da370bb
src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e
src/common/http.cpp 92f063652691a5e1932728d2314c1241c8841109
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/common/type_utils.cpp dc0dd71f52581e2067fed279677bda8c82aa7298
src/docker/docker.cpp 3b934d922ec01fdc9b76681bf937f7a435224688
src/docker/executor.hpp a4a8ec9905d3c6b3afcf0e2ba4e174c41fbcd75a
src/docker/executor.cpp 82ae9bdc94565acb746724c2e6ab6432aa6bd751
src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
src/examples/java/V1TestFramework.java d8bd5cfa539a614413317935e38365b5f7b648b5
src/executor/executor.cpp 9c14054f2bb08c1041138fb297d29ff6fd807792
src/files/files.cpp b03279ee0b23b3a33383c6d3e0c31faa97dab8eb
src/hdfs/hdfs.cpp 2c95a5ea43a4289e1168c527b9ccc35690a751a4
src/internal/evolve.cpp 93196f301e820b99572ee008b98a124ddafe9697
src/launcher/CMakeLists.txt 8b5ffe8a3702681b80ca0e0af609d7a31be5cf0e
src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299
src/launcher/executor.cpp d14fbfb65d1cc44c954c8cdbbf36d7ddf6ede19e
src/launcher/posix/executor.cpp PRE-CREATION
src/launcher/windows/executor.cpp PRE-CREATION
src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
src/linux/fs.hpp cbc8bf79083ce2bc34fa698808eaf92764a577a9
src/linux/ldcache.cpp e93334465911d3ec37f38d51249486d5d317bdb3
src/linux/perf.cpp 5f4f50aa26c5142a3a079ea1103e55e3de96ac30
src/linux/routing/filter/internal.hpp b22a818517e98fecf5ddf96fd0fa2ed95ecde15d
src/master/allocator/mesos/hierarchical.cpp ff9e2340e88f50f02aa8ebfd6b6ce039f347bb5d
src/master/flags.hpp 9336a50d657af319ec8f144a8283e09d8505344f
src/master/flags.cpp b5660e4775c17a773c85491d63ec18777577404a
src/master/http.cpp 0b3c5013550ba7587b467723e2f7c1e70d6a3ce2
src/master/main.cpp 90d159e248924f6806271dda1ced6d37dfa5f5c9
src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034
src/master/master.cpp e547d2c410471f42bfeaae40a8b57ca30033e54f
src/master/quota_handler.cpp 7ff43a048e17b9e9ac0ceed248f7b3fd56b007d6
src/oci/spec.cpp 6cb3255883779fafd657fc9313113d7d209b96f8
src/slave/constants.hpp ef978d6edf1708902dd5da0768d0c5cb80df9d19
src/slave/container_loggers/lib_logrotate.cpp bc13e6a52460d4607873c4b0022165038051bc51
src/slave/containerizer/composing.cpp 0b6c76b3d081d86df81a6062ae7a191ba8dadfde
src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f
src/slave/containerizer/fetcher.cpp a910fea5a5556afb376524c5bb2ff98d7d84e611
src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6
src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 65c1e47a569f320b63b54e5f4fc1da374d02ee0d
src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp fc763bd7834567882146ad25e0266b1183154dc3
src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 18a8066b064835cbd7a2cef6d1a43462bdd5e87c
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d03c14c0834589345eb15db61e67854f3c606637
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp ce795628f19f0e8138ad9a0b50b7d644b9d734a8
src/slave/containerizer/mesos/isolators/posix.hpp caa282c95746e845992c971982892cf60c9b982c
src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
src/slave/containerizer/mesos/launch.cpp 2835beff9dbfa7f2a1cac306a58e2b1d66c14342
src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d
src/slave/containerizer/mesos/launcher.cpp ec31fa24c8b91583b8b327a0c658ed6e87bd292f
src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
src/slave/containerizer/mesos/mount.hpp 038426d57e91e0570003b8c313efc3f6bbb0cd47
src/slave/containerizer/mesos/provisioner/provisioner.cpp be45fc59027f176b43b767e9441fd8089ceec7b4
src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265
src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe
src/slave/http.cpp b07ce7c73a90ef297d980806ebba9530d86f25ae
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
src/slave/paths.hpp 51b481fc0870f1e95448f85ee2fd485fceea1919
src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
src/slave/slave.hpp b26bdf85ec055b5f55a8176d9533000a209fea7c
src/slave/slave.cpp f013e9c7d1c089ec72e2e5db986fd52423ebb8fe
src/slave/state.cpp 33dcc7a148f9a6b1a3216cce45710da8fd819ba6
src/slave/validation.hpp 3a278e43f0e98c1ed6dcdec60e71c131973ccb43
src/slave/windows_ctrlhandler.hpp 145a232bcc8428224ac235864845ab91615ca587
src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d
src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422
src/tests/cluster.cpp 02590a27aadd0583177f21a57ec3d05fe1542f42
src/tests/container_logger_tests.cpp 28436b6b67c1251d877064751e695c6696725a23
src/tests/containerizer/composing_containerizer_tests.cpp d7fd6216080f2f437503b898bff6b1046317933e
src/tests/containerizer/docker_containerizer_tests.cpp 4eef399b05f6e35d75c7c23992f0ccda04576277
src/tests/containerizer/docker_volume_isolator_tests.cpp b47a6b5081a63ac474ac4634701b1a572eb58137
src/tests/containerizer/mesos_containerizer_tests.cpp 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4
src/tests/containerizer/oci_spec_tests.cpp 011e6d0f492c186b3beb3415b0879a5fe7889189
src/tests/containerizer/provisioner_appc_tests.cpp cba83c6f18f6aa720497a8bc80360900a12e43fe
src/tests/containerizer/provisioner_docker_tests.cpp dbbc3533ae269c31c98017d98888d5748ef6e1ce
src/tests/default_executor_tests.cpp 22af7e973f8e6ca583c3126a80bc092bf88fea33
src/tests/executor_http_api_tests.cpp 910dbbfc7cf0d2613b4faeacb77e758a4243a4fb
src/tests/fetcher_cache_tests.cpp 3bd63ed0a66493829a82c542ad05ebe0f7828d1a
src/tests/flags.hpp 664782d03b8d6d9097a45a6f46fb42ec54ab4fe7
src/tests/health_check_tests.cpp c5857b2415faaec4d0557e50cbeb42379f4550ac
src/tests/hook_tests.cpp 02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
src/tests/http_authentication_tests.cpp 99bc257435897f71711329442388ff8e577976c1
src/tests/http_fault_tolerance_tests.cpp 8fcd56d86dcbdd181864756187beb4ff2ac1ff2a
src/tests/master_quota_tests.cpp 1714ba13ea63bae05448d0898bf722ef472c672b
src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
src/tests/mock_slave.hpp 2b30b87db14981909dd44518e06d96f71824c87c
src/tests/mock_slave.cpp 35cd13dbf2848ab4583b5ba21c46b01a17c3e35d
src/tests/partition_tests.cpp 4ff428564d1fa6cb96e6f8ec8edc331da88a3eb6
src/tests/reservation_endpoints_tests.cpp cc8499a5ec05cf7b2283c075e47298918f50bd24
src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
src/tests/role_tests.cpp 0433c0599eac5f4648bc0dfe3a0fa8d5f7a836ca
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
src/tests/secret_generator_tests.cpp 7fd649b2bb403d943955b5df1299c5c58b2c7582
src/tests/slave_recovery_tests.cpp 53f33a2b0411c8158326074ce043c7b1dbeef5b4
src/tests/slave_tests.cpp cd769687e0f161512c0114ef4651508c31f51639
src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a
src/uri/fetchers/copy.cpp 86605a0f3ecc22e7964b093979aecf46954af0f5
src/uri/fetchers/curl.cpp 24b53c77946170cba45152c458d85b6fddfce9f8
src/uri/fetchers/docker.cpp d6d2e8e72554c5f96c3875af8ef93e0bc2107af6
src/v1/mesos.cpp 9c7d6410d3f3e2b93054a77323650c59904ab90e
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
src/webui/master/static/agent_framework.html 06f1697aac91c70f5c0350159ffd26958a8436f1
src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02
support/mesos-tidy.sh 875108ae18c583e24411264983433b902b43412c
support/post-reviews.py 410fb3371a3c46adbfd68c7584ffd6cf3b3010d1
support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/1/
Testing
-------
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li