You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by jennifer lin <jl...@mitre.org> on 2012/01/17 13:42:19 UTC
Review Request: submit request for rave 72-Users can get Widgets from the
Widget Repository that match a tag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3513/
-----------------------------------------------------------
Review request for rave.
Summary
-------
submit request for rave 72-Users can get Widgets from the Widget Repository that match a tag
Diffs
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1232397
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1232397
Diff: https://reviews.apache.org/r/3513/diff
Testing
-------
Thanks,
jennifer
Re: Review Request: submit request for rave 72-Users can get Widgets from
the Widget Repository that match a tag
Posted by jennifer lin <jl...@mitre.org>.
> On 2012-01-19 22:14:59, Marlon Pierce wrote:
> > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java, line 154
> > <https://reviews.apache.org/r/3513/diff/1/?file=69077#file69077line154>
> >
> > By tag search, not free text search.
will fix this
> On 2012-01-19 22:14:59, Marlon Pierce wrote:
> > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java, line 60
> > <https://reviews.apache.org/r/3513/diff/1/?file=69083#file69083line60>
> >
> > Patch needs corresponding modifications to WidgetStoreControllerTest.java
will modify the unit test
> On 2012-01-19 22:14:59, Marlon Pierce wrote:
> > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp, line 23
> > <https://reviews.apache.org/r/3513/diff/1/?file=69087#file69087line23>
> >
> > Although outside this patch, I notice that there is no obvious way to go back to the main store view (you can get there by doing an empty search). I suggest adding a "Widget Store" link to the header when displaying results from either freeform or tag searches.
I already have a link (allWidgets- under search box) that will bring you back to the main store view
> On 2012-01-19 22:14:59, Marlon Pierce wrote:
> > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp, line 77
> > <https://reviews.apache.org/r/3513/diff/1/?file=69087#file69087line77>
> >
> > I think you may want to display something here even if there are no tagged widgets. Otherwise this becomes a hidden feature that we will overlook.
> >
> > It may also be good to tag some of the widgets in initial_data.sql so that the feature will be usable out of the box.
This is search criteria panel. It does not make sense to display an empty list box if a site does not support tags. On the widget store page, we allow users to add/view tags.
> On 2012-01-19 22:14:59, Marlon Pierce wrote:
> > https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java, line 170
> > <https://reviews.apache.org/r/3513/diff/1/?file=69080#file69080line170>
> >
> > Can't you just get this from size of the returned List of widgets?
There are two services, one is to get the total count of widgets by a given tag, the other is to support pagination. In this case, the return list size is the page size.
- jennifer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3513/#review4483
-----------------------------------------------------------
On 2012-01-17 12:42:19, jennifer lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3513/
> -----------------------------------------------------------
>
> (Updated 2012-01-17 12:42:19)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> submit request for rave 72-Users can get Widgets from the Widget Repository that match a tag
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1232397
>
> Diff: https://reviews.apache.org/r/3513/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> jennifer
>
>
Re: Review Request: submit request for rave 72-Users can get Widgets from
the Widget Repository that match a tag
Posted by Marlon Pierce <mp...@cs.indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3513/#review4483
-----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java
<https://reviews.apache.org/r/3513/#comment10063>
By tag search, not free text search.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java
<https://reviews.apache.org/r/3513/#comment10064>
Can't you just get this from size of the returned List of widgets?
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java
<https://reviews.apache.org/r/3513/#comment10061>
Patch needs corresponding modifications to WidgetStoreControllerTest.java
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/3513/#comment10059>
Although outside this patch, I notice that there is no obvious way to go back to the main store view (you can get there by doing an empty search). I suggest adding a "Widget Store" link to the header when displaying results from either freeform or tag searches.
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/3513/#comment10060>
I think you may want to display something here even if there are no tagged widgets. Otherwise this becomes a hidden feature that we will overlook.
It may also be good to tag some of the widgets in initial_data.sql so that the feature will be usable out of the box.
- Marlon
On 2012-01-17 12:42:19, jennifer lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3513/
> -----------------------------------------------------------
>
> (Updated 2012-01-17 12:42:19)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> submit request for rave 72-Users can get Widgets from the Widget Repository that match a tag
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1232397
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1232397
>
> Diff: https://reviews.apache.org/r/3513/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> jennifer
>
>
Re: Review Request: submit request for rave 72-Users can get Widgets from
the Widget Repository that match a tag
Posted by Marlon Pierce <mp...@cs.indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3513/#review4488
-----------------------------------------------------------
Ship it!
I'll commit mid-day if there are no more comments.
- Marlon
On 2012-01-20 13:14:05, jennifer lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3513/
> -----------------------------------------------------------
>
> (Updated 2012-01-20 13:14:05)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> submit request for rave 72-Users can get Widgets from the Widget Repository that match a tag
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1233887
> https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1233887
>
> Diff: https://reviews.apache.org/r/3513/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> jennifer
>
>
Re: Review Request: submit request for rave 72-Users can get Widgets from
the Widget Repository that match a tag
Posted by jennifer lin <jl...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3513/
-----------------------------------------------------------
(Updated 2012-01-20 13:14:05.728033)
Review request for rave.
Changes
-------
fix javadoc
add unit test for controller
Summary
-------
submit request for rave 72-Users can get Widgets from the Widget Repository that match a tag
Diffs (updated)
-----
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultWidgetServiceTest.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1233887
https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1233887
Diff: https://reviews.apache.org/r/3513/diff
Testing
-------
Thanks,
jennifer