[GitHub] [hadoop] szilard-nemeth commented on pull request #5380: YARN-11079. Make an AbstractParentQueue to store common ParentQueue and ManagedParentQueue functionality

["szilard-nemeth (via GitHub)" <gi...@apache.org>]

szilard-nemeth commented on PR #5380:
URL: https://github.com/apache/hadoop/pull/5380#issuecomment-1530426310

   Hi @susheel-gupta ,
   Just took a look at your changes in this PR.
   
   I compared the old version of ParentQueue vs. AbstractParentQueue and found some differences: 
   - the private int field with name 'numApplications' was volatile, now it is changed to AtomicInteger. What is the reason of this? 
   - In the method called 'addApplication', the writelock was locked during incrementing numApplications, now I can see it removed. Do you know why this was necessary?
   - Same for method called 'removeApplication'
   
   Otherwise LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org