You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2012/11/03 00:10:12 UTC
[jira] [Comment Edited] (HBASE-7066) Some HMaster coprocessor
exceptions are being swallowed in try catch blocks
[ https://issues.apache.org/jira/browse/HBASE-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489825#comment-13489825 ]
Andrew Purtell edited comment on HBASE-7066 at 11/2/12 11:09 PM:
-----------------------------------------------------------------
bq. Passing information out of methods via exceptions is always a bit weird.
Maybe in the general case but throwing an access denied exception if a security policy fails check seems natural, common, and unsurprising to me.
bq. Can we instead make the coprocessor protocol be more explicit?
One early thought was an Enum instead of a Boolean. We went with "simpler is better". Changing this internal framework detail if we need it now seems reasonable to me.
was (Author: apurtell):
bq. Passing information out of methods via exceptions is always a bit weird.
Maybe in the general case but throwing an access denied exception if a security policy check seems natural, common, and unsurprising to me.
bq. Can we instead make the coprocessor protocol be more explicit?
One early thought was an Enum instead of a Boolean. We went with "simpler is better". Changing this internal framework detail if we need it now seems reasonable to me.
> Some HMaster coprocessor exceptions are being swallowed in try catch blocks
> ---------------------------------------------------------------------------
>
> Key: HBASE-7066
> URL: https://issues.apache.org/jira/browse/HBASE-7066
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, security
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Priority: Critical
> Attachments: HBASE-7066_94.patch, HBASE-7066_trunk.patch, HBASE-7066_trunk.patch
>
>
> This is causing HMaster.shutdown() and HMaster.stopMaster() to succeed even when an AccessDeniedException is thrown.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira