You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Jaswanth-arjun (via GitHub)" <gi...@apache.org> on 2026/03/19 05:10:09 UTC
[PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Jaswanth-arjun opened a new pull request, #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336
### Problem
The PluginEditorDrawer used a fixed editor height which caused overflow issues.
On smaller or medium-height screens, the Monaco editor pushed the Add/Save
actions outside the visible area, making them difficult to access.
### Solution
- Removed fixed height from the editor
- Introduced a flex-based column layout
- Made the content area scrollable
- Added a sticky footer to keep Add/Save actions always visible
### Result
- Add/Save buttons are always accessible
- Layout adapts correctly to different screen sizes
- Improved usability when editing large plugin configurations
### Scope
- Changes are limited to PluginEditorDrawer layout
- No changes to API or business logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Jaswanth-arjun (via GitHub)" <gi...@apache.org>.
Jaswanth-arjun commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4095724903
Hi @Baoyuantop i submitted solution by PR not creating issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Jaswanth-arjun (via GitHub)" <gi...@apache.org>.
Jaswanth-arjun commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4096003258
hoo @Baoyuantop i am sorry i am begginner i dont know really how to contribute i am taking guidence from chatgpt ,the steps it telling i am falowing ,it told me to find apropriate issue i found it and i fixed the bug with my knowledge later i asked chatgpt what should i do next it told me to do PR to respective issue thats it i done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4124135396
As I stated in the original issue, this is not a genuine question, and the original issue has been closed, so this PR will also be closed. Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Jaswanth-arjun (via GitHub)" <gi...@apache.org>.
Jaswanth-arjun commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4124159683
Hi @Baoyuantop,
Thank you for the clarification and feedback.
I understand now that the issue is not considered valid, and I appreciate your guidance on the contribution process. I will make sure to first confirm or create an approved issue before submitting a PR next time.
Thanks again for your time and support!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4088933021
Hi @Jaswanth-arjun, please start by creating an issue describing your problem. If it's a UI issue, please include a screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4095972861
Hi @Jaswanth-arjun, when you encounter a problem, please check if an issue already describes it. If not, you will need to create one yourself. Please do not submit a pull request (PR) that is not associated with any issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Jaswanth-arjun (via GitHub)" <gi...@apache.org>.
Jaswanth-arjun commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4087856115
Hi, I’ve implemented a fix for this issue by replacing the fixed height layout with a responsive flex-based structure and making the action buttons sticky.
Please review my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop closed pull request #3336: fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible
URL: https://github.com/apache/apisix-dashboard/pull/3336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4107745550
Hi @Jaswanth-arjun, please update the description of your PR to include the issue number it resolves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(plugin): prevent overflow in PluginEditorDrawer and keep Add/Save visible [apisix-dashboard]
Posted by "Jaswanth-arjun (via GitHub)" <gi...@apache.org>.
Jaswanth-arjun commented on PR #3336:
URL: https://github.com/apache/apisix-dashboard/pull/3336#issuecomment-4109079310
Yeah @Baoyuantop i updated now could you please review my PR now..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org