[jira] [Commented] (HADOOP-18560) AvroFSInput opens a stream twice and discards the second one without closing

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643464#comment-17643464 ] 

ASF GitHub Bot commented on HADOOP-18560:
-----------------------------------------

steveloughran opened a new pull request, #5186:
URL: https://github.com/apache/hadoop/pull/5186

   
   ### Description of PR
   
   removes a needless line in `AvroFSInput(final FileContext fc, final Path p` which opens the path a second time and discards the result.
   
   on input streams which immediately set up a connection with the store, this can leak connections.
   
   Note, this is through the FileContext constructor, which is only used in production in org.apache.hadoop.fs.shell.Display, which being used from the command line, shouldn't be a long-lived process
   
   ### How was this patch tested?
   
   going to see what yetus says.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> AvroFSInput opens a stream twice and discards the second one without closing
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-18560
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18560
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 3.3.5
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>
> late breaking blocker for 3.3.5; AvroFsinput can leak input streams because the change of HADOOP-16202 failed to comment out the original open() call.
> noticed during a code review with [~harshit.gupta]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org