You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/12 15:01:01 UTC

[GitHub] [geode] jmelchio commented on pull request #7248: GEODE-9933: documentation for authorization expiry

jmelchio commented on pull request #7248:
URL: https://github.com/apache/geode/pull/7248#issuecomment-1011133433


   > @jmelchio Thanks for your contribution to the user guide! I approve the two example files as-is. I request a few changes to the implementation files - I've attached a diff containing these changes. One change is mandatory in each file - please replace Geode with the product_name variable (see diff for syntax). A discretionary change in the implementing_authentication file would be my suggested re-phrasing (three occurrences) that emphasizes that the token is one alternative, and that the username/password combination is a second alternative. Your choice on this one - read it and see what you think. [GEODE-9933.DIFF.zip](https://github.com/apache/geode/files/7850178/GEODE-9933.DIFF.zip)
   
   Thanks @davebarnes97, I've applied the patch file and pushed the commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org