[GitHub] [ozone] elek commented on a change in pull request #2096: HDDS-5047. Refactor Pipeline to use ReplicationConfig instead of factor/type

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #2096:
URL: https://github.com/apache/ozone/pull/2096#discussion_r613174447



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineManagerImpl.java
##########
@@ -131,12 +133,12 @@ public void testCreatePipeline() throws Exception {
         createPipelineManager(true, buffer1);
     Assert.assertTrue(pipelineManager.getPipelines().isEmpty());
     Pipeline pipeline1 = pipelineManager.createPipeline(
-        HddsProtos.ReplicationType.RATIS, HddsProtos.ReplicationFactor.THREE);
+        new RatisReplicationConfig(ReplicationFactor.THREE));
     Assert.assertEquals(1, pipelineManager.getPipelines().size());
     Assert.assertTrue(pipelineManager.containsPipeline(pipeline1.getId()));
 
     Pipeline pipeline2 = pipelineManager.createPipeline(
-        HddsProtos.ReplicationType.RATIS, HddsProtos.ReplicationFactor.ONE);
+        new RatisReplicationConfig(ReplicationFactor.THREE));

Review comment:
       Good point, thanks. Fixing it. (BTW, it seems to be the limitation of the unit test. Pipeline parameters are not checked, so it can be ONE/THREE, but let's keep it as it was)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org