[GitHub] [orc] omalley commented on a change in pull request #522: ORC-644: Support positional mapping for nested types

[GitBox <gi...@apache.org>]

omalley commented on a change in pull request #522:
URL: https://github.com/apache/orc/pull/522#discussion_r474313405



##########
File path: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java
##########
@@ -123,7 +123,7 @@ public SchemaEvolution(TypeDescription fileSchema,
           }
         }
       }
-      buildConversion(fileSchema, this.readerSchema, positionalLevels);
+      buildConversion(fileSchema, this.readerSchema, positionalLevels, options.isForcePositionalEvolutionNestedTypes());

Review comment:
       Can't you just set positionalLevels to Integer.MAX_VALUE?

##########
File path: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java
##########
@@ -18,19 +18,19 @@
 
 package org.apache.orc.impl;
 
+import org.apache.hadoop.conf.Configuration;

Review comment:
       Can you undo the movement of the imports?

##########
File path: java/core/src/test/org/apache/orc/impl/TestSchemaEvolution.java
##########
@@ -61,6 +44,24 @@
 import org.junit.Test;
 import org.junit.rules.TestName;
 
+import java.io.File;

Review comment:
       Please undo the movement of the imports.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org