You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/28 07:39:19 UTC

[GitHub] flink pull request #4002: [6730] Apply non-invasive checkstyle rules to flin...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4002

    [6730] Apply non-invasive checkstyle rules to flink-optimizer

    This PR applys3 non-invasive checkstyle rules to flink-optimizer. It reorders imports, adds an empty line before the package declaration and removes multiple subsequent empty lines.
    
    Note that the actual checkstyle enforcement in flink-optimizer wasn't changed. The above checks should be added to the default checkstyle once we've applied PRs like this for the remaining modules.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6730csopt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4002.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4002
    
----
commit 4e3760e55580dd5e0ae195496a36e0d10c3104e1
Author: zentol <ch...@apache.org>
Date:   2017-05-28T07:11:10Z

    [FLINK-6739] Apply checkstyle import order to flink-optimizer

commit 9d39229e223f5f76554659d6572ad7677e997c3b
Author: zentol <ch...@apache.org>
Date:   2017-05-28T07:13:41Z

    [FLINK-6730] Apply empty line before package declaration in flink-optimizer

commit 3254805a390d0a7c7b43fae067b5fb2ffd3ed809
Author: zentol <ch...@apache.org>
Date:   2017-05-28T07:32:26Z

    [FLINK-6730] Remove multiple empty lines in flink-optimizer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4002: [FLINK-6730] Apply non-invasive checkstyle rules t...

Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:

    https://github.com/apache/flink/pull/4002


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4002: [FLINK-6730] Apply non-invasive checkstyle rules to flink...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4002
  
    Closing this PR for now while we discuss the general approach for non-(flink-runtime) modules.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---