You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Andrey Mashenkov (Jira)" <ji...@apache.org> on 2022/10/26 14:54:00 UTC
[jira] [Assigned] (IGNITE-17771) Get rid of internal classes in API module.
[ https://issues.apache.org/jira/browse/IGNITE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Mashenkov reassigned IGNITE-17771:
-----------------------------------------
Assignee: Andrey Mashenkov
> Get rid of internal classes in API module.
> ------------------------------------------
>
> Key: IGNITE-17771
> URL: https://issues.apache.org/jira/browse/IGNITE-17771
> Project: Ignite
> Issue Type: Improvement
> Reporter: Andrey Mashenkov
> Assignee: Andrey Mashenkov
> Priority: Major
> Labels: ignite-3, tech-debt
>
> Let's move 2 internal classes from ignite-api module.
> # org.apache.ignite.internal.sql.ResultSetImpl
> # org.apache.ignite.internal.sql.SqlColumnTypeConverter
> h3. Motivation.
> ResultSetImpl is just a wrapper over asynchronous resultset and was introduced to avoid unwanted code duplication as it is used in 2 modules (client and sql-engine).
> However, we may want to convert exception in different ways on clients and in embedded mode. So, having 2 similar implementations look acceptable.
> SqlColumnTypeConverter is utility class with a single static method, which converts SqlColumnType -> Java class. We can get rid of the class and add SqlColumnType.toJavaType() method instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)