You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Johan Compagner (JIRA)" <ji...@apache.org> on 2007/04/18 09:40:15 UTC
[jira] Created: (WICKET-479) MarkupComponentBorder should be
backported correctly (code is commented out at this time)
MarkupComponentBorder should be backported correctly (code is commented out at this time)
-----------------------------------------------------------------------------------------
Key: WICKET-479
URL: https://issues.apache.org/jira/browse/WICKET-479
Project: Wicket
Issue Type: Task
Components: wicket
Affects Versions: 1.3
Reporter: Johan Compagner
Assigned To: Igor Vaynberg
The MarkupComponentBorder java file is already brought to 1.3
(and everything else should work fine now, we need some simple unit test for this)
But because it did use 2.0 MarkupFragement stuff:
/* MarkupFragment markupFragment = findMarkup(extension);
MarkupFragment childFragment = markupFragment.getWicketFragment(Border.BORDER, true);
List allElementsFlat = childFragment.getAllElementsFlat();
Response response = component.getResponse();
it doens't work in 1.3 currently because that isn't going to be backported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-479) MarkupComponentBorder should be
backported correctly (code is commented out at this time)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-479:
---------------------------------
Attachment: MarkupComponentBorder.java
here is my wip
feel free to commit it, my svn switch got borked and im too tired to recheck out right now.
i havent tested it, but it should be very close.
now where is my attach refactor johan?!? :)
> MarkupComponentBorder should be backported correctly (code is commented out at this time)
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-479
> URL: https://issues.apache.org/jira/browse/WICKET-479
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 1.3
> Reporter: Johan Compagner
> Assigned To: Igor Vaynberg
> Attachments: MarkupComponentBorder.java
>
>
> The MarkupComponentBorder java file is already brought to 1.3
> (and everything else should work fine now, we need some simple unit test for this)
> But because it did use 2.0 MarkupFragement stuff:
> /* MarkupFragment markupFragment = findMarkup(extension);
> MarkupFragment childFragment = markupFragment.getWicketFragment(Border.BORDER, true);
> List allElementsFlat = childFragment.getAllElementsFlat();
> Response response = component.getResponse();
> it doens't work in 1.3 currently because that isn't going to be backported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-479) MarkupComponentBorder should be
backported correctly (code is commented out at this time)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489981 ]
Johan Compagner commented on WICKET-479:
----------------------------------------
i guess i had to add public ContainerInfo(Class containerClass, Locale locale, String style, String markupType) ?
because i got a compile error! Thats not good!
> MarkupComponentBorder should be backported correctly (code is commented out at this time)
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-479
> URL: https://issues.apache.org/jira/browse/WICKET-479
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 1.3
> Reporter: Johan Compagner
> Assigned To: Igor Vaynberg
> Attachments: MarkupComponentBorder.java
>
>
> The MarkupComponentBorder java file is already brought to 1.3
> (and everything else should work fine now, we need some simple unit test for this)
> But because it did use 2.0 MarkupFragement stuff:
> /* MarkupFragment markupFragment = findMarkup(extension);
> MarkupFragment childFragment = markupFragment.getWicketFragment(Border.BORDER, true);
> List allElementsFlat = childFragment.getAllElementsFlat();
> Response response = component.getResponse();
> it doens't work in 1.3 currently because that isn't going to be backported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-479) MarkupComponentBorder should be
backported correctly (code is commented out at this time)
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-479.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.3
Assignee: Johan Compagner (was: Igor Vaynberg)
i had to fix some more stuff to get it completely working correctly.
Addes a unit test
and FormInput has an example.
> MarkupComponentBorder should be backported correctly (code is commented out at this time)
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-479
> URL: https://issues.apache.org/jira/browse/WICKET-479
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 1.3
> Reporter: Johan Compagner
> Assigned To: Johan Compagner
> Fix For: 1.3
>
> Attachments: MarkupComponentBorder.java
>
>
> The MarkupComponentBorder java file is already brought to 1.3
> (and everything else should work fine now, we need some simple unit test for this)
> But because it did use 2.0 MarkupFragement stuff:
> /* MarkupFragment markupFragment = findMarkup(extension);
> MarkupFragment childFragment = markupFragment.getWicketFragment(Border.BORDER, true);
> List allElementsFlat = childFragment.getAllElementsFlat();
> Response response = component.getResponse();
> it doens't work in 1.3 currently because that isn't going to be backported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-479) MarkupComponentBorder should be
backported correctly (code is commented out at this time)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490112 ]
Igor Vaynberg commented on WICKET-479:
--------------------------------------
yeah, forgot to tell you that
did you try it? works?
> MarkupComponentBorder should be backported correctly (code is commented out at this time)
> -----------------------------------------------------------------------------------------
>
> Key: WICKET-479
> URL: https://issues.apache.org/jira/browse/WICKET-479
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 1.3
> Reporter: Johan Compagner
> Assigned To: Igor Vaynberg
> Attachments: MarkupComponentBorder.java
>
>
> The MarkupComponentBorder java file is already brought to 1.3
> (and everything else should work fine now, we need some simple unit test for this)
> But because it did use 2.0 MarkupFragement stuff:
> /* MarkupFragment markupFragment = findMarkup(extension);
> MarkupFragment childFragment = markupFragment.getWicketFragment(Border.BORDER, true);
> List allElementsFlat = childFragment.getAllElementsFlat();
> Response response = component.getResponse();
> it doens't work in 1.3 currently because that isn't going to be backported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.