You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "zhaoyunxing92 (via GitHub)" <gi...@apache.org> on 2023/08/31 09:09:26 UTC
[GitHub] [skywalking-java] zhaoyunxing92 opened a new pull request, #601: Support maven revision
zhaoyunxing92 opened a new pull request, #601:
URL: https://github.com/apache/skywalking-java/pull/601
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist π ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== π Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
### <Feature description>
- [x] [Using of CI friendly versions ](https://maven.apache.org/docs/3.5.0/release-notes.html#overview-about-the-changes) eg: `mvnd clean package -Dmaven.test.skip=true -Drevision=8.16.12 -Pall`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700850277
I saw that a bunch of files have to be modified every time I publish. Now I donβt need to modify the files, or I only need to modify one, and this is compatible with your previous ones. This is supported in maven3.5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on a diff in pull request #601: Support maven revision
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#discussion_r1312476584
##########
pom.xml:
##########
@@ -79,6 +79,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<compiler.version>8</compiler.version>
+ <revision>9.1.0-SNAPSHOT</revision>
Review Comment:
> This has to be manually changed to 9.1.0 for release and tag, and then 9.2.0-SNAPSHOT for the next dev stage.
This doesn't actually need to be manually changed, when you run the release command, you'll be prompted like before about what the version is, what the next SNAPSHOT version is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700837669
But the modified files are different, now only one file needs to be modified, even without modifying the command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#discussion_r1312467626
##########
pom.xml:
##########
@@ -79,6 +79,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<compiler.version>8</compiler.version>
+ <revision>9.1.0-SNAPSHOT</revision>
Review Comment:
This has to be manually changed to 9.1.0 for release and tag, and then 9.2.0-SNAPSHOT for the next dev stage.
What do you mean as same as before? You are not an upstream release manager, I don't think you have gone through all Java agent release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700735637
We don't need to change any files manually. We just run one command only. That is my confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1702016617
> You are not reading clearly about Zhenxu posted previously. [This command](https://github.com/apache/skywalking/blob/1256f7059df3affd73c27d1b17a3cf8d7ea6efff/docs/en/guides/How-to-release.md?plain=1#L48) would do all the changes and even `git tag`/`git commit` from v1-SNAPSHOT to v1 and then v2-SNAPSHOT automatically.
I have read this, but I feel that I can try a new release method. I modified too many files in each previous release, and now I donβt need to modify the files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on pull request #601: Support maven revision
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700674333
> > This is never discussed. Why do you add this?
>
> Unify the version management in the parent class, which is convenient for publishing and packaging without modifying a version file every time you publish
Is this compatible with the maven-publish plugin as well as the Apache release procedure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wuwen5 commented on pull request #601: Support maven revision
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700766035
In my personal opinion, this is not a best practice (`-Drevision=x.y.z`) and I do not believe it is a standard release process. It can release a version that is inconsistent with the source code before git tag.
It seems that this is a non mainstream approachοΌ And this way brings trouble to regular build operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700703978
I can't see the point of using this. If you need to package for specific version, why don't you use the give git tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #601: Support maven revision
URL: https://github.com/apache/skywalking-java/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700663618
> This is never discussed. Why do you add this?
Unify the version management in the parent class, which is convenient for publishing and packaging without modifying a version file every time you publish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700692561
> > > This is never discussed. Why do you add this?
> >
> >
> > Unify the version management in the parent class, which is convenient for publishing and packaging without modifying a version file every time you publish
>
> Is this compatible with the maven-publish plugin as well as the Apache release procedure?
Compatible. In the past, `mvn versions:set -DnewVersion=9.1.0` may be used to modify the version number in batches. Now it is only used to modify one place in the pom file. If you use the command, you can use `-Drevision=9.1.0` to modify, eg: `mvnd clean package -Dmaven.test.skip=true -Drevision=8.16.12 -Pall`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on pull request #601: Support maven revision
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700705710
> > > > This is never discussed. Why do you add this?
> > >
> > >
> > > Unify the version management in the parent class, which is convenient for publishing and packaging without modifying a version file every time you publish
> >
> >
> > Is this compatible with the maven-publish plugin as well as the Apache release procedure?
>
> Compatible. In the past, `mvn versions:set -DnewVersion=9.1.0` may be used to modify the version number in batches. Now it is only used to modify one place in the pom file. If you use the command, you can use `-Drevision=9.1.0` to modify, eg: `mvnd clean package -Dmaven.test.skip=true -Drevision=8.16.12 -Pall`
Check the full steps about how to do the release, and verify the changes in this PR is OK in those process
https://github.com/apache/skywalking/blob/1256f7059df3affd73c27d1b17a3cf8d7ea6efff/docs/en/guides/How-to-release.md?plain=1#L48
If so I'm glad to approve the changes so that we don't have to change hundreds of lines in every release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700659179
This is never discussed. Why do you add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1702021395
That is your practice, not an upstream case.
For us, you are actually adding a new manual file change, rather than an all automatic process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1702023606
> That is your practice, not an upstream case. For us, you are actually adding a new manual file change, rather than an all automatic process.
He is compatible with the previous release method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] zhaoyunxing92 commented on pull request #601: Support maven revision
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700712690
> > > > > This is never discussed. Why do you add this?
> > > >
> > > >
> > > > Unify the version management in the parent class, which is convenient for publishing and packaging without modifying a version file every time you publish
> > >
> > >
> > > Is this compatible with the maven-publish plugin as well as the Apache release procedure?
> >
> >
> > Compatible. In the past, `mvn versions:set -DnewVersion=9.1.0` may be used to modify the version number in batches. Now it is only used to modify one place in the pom file. If you use the command, you can use `-Drevision=9.1.0` to modify, eg: `mvnd clean package -Dmaven.test.skip=true -Drevision=8.16.12 -Pall`
>
> That's not how we do a release, check the full steps about how to do the release, and verify the changes in this PR is OK in those process
>
> https://github.com/apache/skywalking/blob/1256f7059df3affd73c27d1b17a3cf8d7ea6efff/docs/en/guides/How-to-release.md?plain=1#L48
>
> If so I'm glad to approve the changes so that we don't have to change hundreds of lines in every release.
Yes, you only need to modify one file for future releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #601: Support maven revision
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #601:
URL: https://github.com/apache/skywalking-java/pull/601#issuecomment-1700973862
You are not readin clearly about Zhenxu posted previously. [This command](https://github.com/apache/skywalking/blob/1256f7059df3affd73c27d1b17a3cf8d7ea6efff/docs/en/guides/How-to-release.md?plain=1#L48) would do all the changes and even `git tag`/`git commit` from v1-SNAPSHOT to v1 and then v2-SNAPSHOT automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org