Re: Broken links in code velocity dashboard

[Ahmet Altay <al...@google.com>]

Damian, or anyone else, do you know if there were other changes to the
dashboard?

I started to see closed PRs in the currently open PRs list (e.g.
https://github.com/apache/beam/pull/12349,
https://github.com/apache/beam/pull/12374). Not sure what is causing it,
but it seems like a new issue.

On Fri, Jul 31, 2020 at 10:13 AM Ahmet Altay <al...@google.com> wrote:

> Looks fixed. Thank you for the quick response!
>
> On Fri, Jul 31, 2020 at 7:05 AM Damian Gadomski <
> damian.gadomski@polidea.com> wrote:
>
>> Oops. Sorry about that. Everything should be fixed now. URLs are correct
>> and I've also removed wrong entries from the DB.
>>
>> If you're curious, you were right, it was mistakenly deployed from my
>> fork. Actually, my private Jenkins instance did it. Will be more cautious
>> with the jobs.
>>
>> Regards,
>> Damian
>>
>> On Fri, Jul 31, 2020 at 1:32 AM Ahmet Altay <al...@google.com> wrote:
>>
>>> Currently the open PRs section of the dashboard [1] seems to be broken.
>>> PRs are linking to https://github.com/damgadbot/beam/issues/<PR NUMBER>
>>> instead of https://github.com/apache/beam/pull/<PR NUMBER>. And the PR
>>> list showing PRs from the (https://github.com/damgadbot/beam) fork in
>>> addition to the main repo.
>>>
>>> Dashboard was working normally last week, so probably something changed
>>> recently. I do not see a code change in the dashboard [2]. I am not sure
>>> what happened, maybe the dashboard was deployed from a fork?
>>>
>>> +Damian Gadomski <da...@polidea.com> - based on the url
>>> changes :)
>>>
>>> Thank you,
>>> Ahmet
>>>
>>> [1] http://metrics.beam.apache.org/d/code_velocity/code-velocity?orgId=1
>>> [2]
>>> https://github.com/apache/beam/blob/master/.test-infra/metrics/grafana/dashboards/code_velocity.json
>>>
>>

Re: Broken links in code velocity dashboard

[Ahmet Altay <al...@google.com>]

Thank you Damian. Thank you Udi. I use the code velocity dashboard
regularly, if I can find time I will try to debug it. Since I reported the
same thing a year ago and forgot about it, it does not seem like this issue
is bothering me much :)

On Mon, Aug 10, 2020 at 11:55 AM Udi Meiri <eh...@google.com> wrote:

> There's this old bug about it:
> https://issues.apache.org/jira/browse/BEAM-8389
>
> On Fri, Aug 7, 2020 at 4:45 AM Damian Gadomski <
> damian.gadomski@polidea.com> wrote:
>
>> Unfortunately, I'm not aware of any recent changes.
>>
>> On Thu, Aug 6, 2020 at 10:00 PM Ahmet Altay <al...@google.com> wrote:
>>
>>> Damian, or anyone else, do you know if there were other changes to the
>>> dashboard?
>>>
>>> I started to see closed PRs in the currently open PRs list (e.g.
>>> https://github.com/apache/beam/pull/12349,
>>> https://github.com/apache/beam/pull/12374). Not sure what is causing
>>> it, but it seems like a new issue.
>>>
>>> On Fri, Jul 31, 2020 at 10:13 AM Ahmet Altay <al...@google.com> wrote:
>>>
>>>> Looks fixed. Thank you for the quick response!
>>>>
>>>> On Fri, Jul 31, 2020 at 7:05 AM Damian Gadomski <
>>>> damian.gadomski@polidea.com> wrote:
>>>>
>>>>> Oops. Sorry about that. Everything should be fixed now. URLs are
>>>>> correct and I've also removed wrong entries from the DB.
>>>>>
>>>>> If you're curious, you were right, it was mistakenly deployed from my
>>>>> fork. Actually, my private Jenkins instance did it. Will be more cautious
>>>>> with the jobs.
>>>>>
>>>>> Regards,
>>>>> Damian
>>>>>
>>>>> On Fri, Jul 31, 2020 at 1:32 AM Ahmet Altay <al...@google.com> wrote:
>>>>>
>>>>>> Currently the open PRs section of the dashboard [1] seems to be
>>>>>> broken. PRs are linking to https://github.com/damgadbot/beam/issues/<PR
>>>>>> NUMBER> instead of https://github.com/apache/beam/pull/<PR NUMBER>.
>>>>>> And the PR list showing PRs from the (
>>>>>> https://github.com/damgadbot/beam) fork in addition to the main
>>>>>> repo.
>>>>>>
>>>>>> Dashboard was working normally last week, so probably something
>>>>>> changed recently. I do not see a code change in the dashboard [2]. I am not
>>>>>> sure what happened, maybe the dashboard was deployed from a fork?
>>>>>>
>>>>>> +Damian Gadomski <da...@polidea.com> - based on the url
>>>>>> changes :)
>>>>>>
>>>>>> Thank you,
>>>>>> Ahmet
>>>>>>
>>>>>> [1]
>>>>>> http://metrics.beam.apache.org/d/code_velocity/code-velocity?orgId=1
>>>>>> [2]
>>>>>> https://github.com/apache/beam/blob/master/.test-infra/metrics/grafana/dashboards/code_velocity.json
>>>>>>
>>>>>

Re: Broken links in code velocity dashboard

[Udi Meiri <eh...@google.com>]

There's this old bug about it:
https://issues.apache.org/jira/browse/BEAM-8389

On Fri, Aug 7, 2020 at 4:45 AM Damian Gadomski <da...@polidea.com>
wrote:

> Unfortunately, I'm not aware of any recent changes.
>
> On Thu, Aug 6, 2020 at 10:00 PM Ahmet Altay <al...@google.com> wrote:
>
>> Damian, or anyone else, do you know if there were other changes to the
>> dashboard?
>>
>> I started to see closed PRs in the currently open PRs list (e.g.
>> https://github.com/apache/beam/pull/12349,
>> https://github.com/apache/beam/pull/12374). Not sure what is causing it,
>> but it seems like a new issue.
>>
>> On Fri, Jul 31, 2020 at 10:13 AM Ahmet Altay <al...@google.com> wrote:
>>
>>> Looks fixed. Thank you for the quick response!
>>>
>>> On Fri, Jul 31, 2020 at 7:05 AM Damian Gadomski <
>>> damian.gadomski@polidea.com> wrote:
>>>
>>>> Oops. Sorry about that. Everything should be fixed now. URLs are
>>>> correct and I've also removed wrong entries from the DB.
>>>>
>>>> If you're curious, you were right, it was mistakenly deployed from my
>>>> fork. Actually, my private Jenkins instance did it. Will be more cautious
>>>> with the jobs.
>>>>
>>>> Regards,
>>>> Damian
>>>>
>>>> On Fri, Jul 31, 2020 at 1:32 AM Ahmet Altay <al...@google.com> wrote:
>>>>
>>>>> Currently the open PRs section of the dashboard [1] seems to be
>>>>> broken. PRs are linking to https://github.com/damgadbot/beam/issues/<PR
>>>>> NUMBER> instead of https://github.com/apache/beam/pull/<PR NUMBER>.
>>>>> And the PR list showing PRs from the (
>>>>> https://github.com/damgadbot/beam) fork in addition to the main repo.
>>>>>
>>>>> Dashboard was working normally last week, so probably something
>>>>> changed recently. I do not see a code change in the dashboard [2]. I am not
>>>>> sure what happened, maybe the dashboard was deployed from a fork?
>>>>>
>>>>> +Damian Gadomski <da...@polidea.com> - based on the url
>>>>> changes :)
>>>>>
>>>>> Thank you,
>>>>> Ahmet
>>>>>
>>>>> [1]
>>>>> http://metrics.beam.apache.org/d/code_velocity/code-velocity?orgId=1
>>>>> [2]
>>>>> https://github.com/apache/beam/blob/master/.test-infra/metrics/grafana/dashboards/code_velocity.json
>>>>>
>>>>

Re: Broken links in code velocity dashboard

[Damian Gadomski <da...@polidea.com>]

Unfortunately, I'm not aware of any recent changes.

On Thu, Aug 6, 2020 at 10:00 PM Ahmet Altay <al...@google.com> wrote:

> Damian, or anyone else, do you know if there were other changes to the
> dashboard?
>
> I started to see closed PRs in the currently open PRs list (e.g.
> https://github.com/apache/beam/pull/12349,
> https://github.com/apache/beam/pull/12374). Not sure what is causing it,
> but it seems like a new issue.
>
> On Fri, Jul 31, 2020 at 10:13 AM Ahmet Altay <al...@google.com> wrote:
>
>> Looks fixed. Thank you for the quick response!
>>
>> On Fri, Jul 31, 2020 at 7:05 AM Damian Gadomski <
>> damian.gadomski@polidea.com> wrote:
>>
>>> Oops. Sorry about that. Everything should be fixed now. URLs are correct
>>> and I've also removed wrong entries from the DB.
>>>
>>> If you're curious, you were right, it was mistakenly deployed from my
>>> fork. Actually, my private Jenkins instance did it. Will be more cautious
>>> with the jobs.
>>>
>>> Regards,
>>> Damian
>>>
>>> On Fri, Jul 31, 2020 at 1:32 AM Ahmet Altay <al...@google.com> wrote:
>>>
>>>> Currently the open PRs section of the dashboard [1] seems to be broken.
>>>> PRs are linking to https://github.com/damgadbot/beam/issues/<PR
>>>> NUMBER> instead of https://github.com/apache/beam/pull/<PR NUMBER>.
>>>> And the PR list showing PRs from the (https://github.com/damgadbot/beam)
>>>> fork in addition to the main repo.
>>>>
>>>> Dashboard was working normally last week, so probably something changed
>>>> recently. I do not see a code change in the dashboard [2]. I am not sure
>>>> what happened, maybe the dashboard was deployed from a fork?
>>>>
>>>> +Damian Gadomski <da...@polidea.com> - based on the url
>>>> changes :)
>>>>
>>>> Thank you,
>>>> Ahmet
>>>>
>>>> [1]
>>>> http://metrics.beam.apache.org/d/code_velocity/code-velocity?orgId=1
>>>> [2]
>>>> https://github.com/apache/beam/blob/master/.test-infra/metrics/grafana/dashboards/code_velocity.json
>>>>
>>>