You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2017/10/31 22:43:17 UTC
[Bug 7492] New: Improve SA performance by removing the use of "use
vars" from production code.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7492
Bug ID: 7492
Summary: Improve SA performance by removing the use of "use
vars" from production code.
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: toddr@cpanel.net
Target Milestone: Undefined
SpamAssassin still uses "use vars" instead of our. "use vars" has been
discouraged since Perl 5.6. SpamAssassin requires Perl 5.8.4 as a minimum Perl
as best I can tell.
use vars has a memory impact to the running process and is for the most part
unnecessary. I am submitting a patch which removes its use.
I am not submitting changes to t/ since that fix is significantly more complex
due to the use of package main in t/SATest.pm (needs BZ 7491 merged first).
Patch coming soon.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7492] Improve SA performance by removing the use of "use vars"
from production code.
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7492
--- Comment #3 from Todd Rinaldo <to...@cpanel.net> ---
CLA is now signed. Could we get a patch review please?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7492] Improve SA performance by removing the use of "use vars"
from production code.
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7492
Todd Rinaldo <to...@cpanel.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |toddr@cpanel.net
--- Comment #1 from Todd Rinaldo <to...@cpanel.net> ---
Created attachment 5470
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5470&action=edit
Remove the use of use vars from the production code base.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7492] Improve SA performance by removing the use of "use vars"
from production code.
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7492
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Kevin A. McGrail <km...@apache.org> ---
BZ 7491 done as prerequisite and patch applied. Took some work on the 3.4
branch but I think it's clean.
3.4:
Committed revision 1823175.
Trunk:
Committed revision 1823176.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7492] Improve SA performance by removing the use of "use vars"
from production code.
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7492
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@apache.org
--- Comment #2 from Kevin A. McGrail <km...@apache.org> ---
Todd, as discussed, we welcome the patches and look forward to the ICLA/CCLA
discussed so we can consider them more fully!
Best,
KAM
--
You are receiving this mail because:
You are the assignee for the bug.