You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/19 09:43:54 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #12832: Extent filtered by other axis
100pah opened a new pull request #12832:
URL: https://github.com/apache/incubator-echarts/pull/12832
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
#### fix: some refactor about dataZoom and axis scale extent calculation:
+ The "scale extent calculation" is depended by both coord sys and "dataZoom".
So it need to be performed in different stage of workflow and should avoid to call it repleatly or implement it repeatly.
But previously, the "scale extent calculation" is implemented both in `axisHelper.ts` and `dataZoom/AxisProxy.ts`,
where different code implements similar logic.
"Scale extent calculation" is based on input of:
(I) option specified min/max/scale (including callback) and
(II) dataExtent and
(III) some filter related components like dataZoom.
Currently we need add more filters depends on that axis scale calculation.
e.g.,
(I) one axis min max effect the other axis extent
(II) custom filter.
So we refactor that "Scale extent calculation" as a reusable module (see `scaleRawExtentInfo.ts`).
+ Based on (1), make the callback of axis.min/axis.max consistent whatever it is called in
"data processing stage" or "coord sys updating stage"
+ Based on (1), fix some "inconsistent" flaw in dataZoom when handling stacked series.
+ Fix the type of axis.min/max to `ScaleDataValue`. And enable the callback of axis.min/max to return `ScaleDataValue`.
+ Remove some code that never used.
+ Make the "data filter", which will "block stream", not as the default data processor in the register API.
#### feature: Enable category axis min/max to shrink the other axis extent in cartesian.
After this modification, if some data if out of the range of a category axis,
the data item will not be filtered, but the extent of the other axis will be calculated
based on the filtered data.
If dataZoom is used in either of the xAxis or yAxis in that cartesian, the shrink will not be performed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #12832: Extent filtered by other axis
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #12832:
URL: https://github.com/apache/incubator-echarts/pull/12832#discussion_r442745044
##########
File path: src/coord/axisHelper.ts
##########
@@ -1,6 +1,6 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
-* or more contributor license agreements. See the NOTICE file
+* or more contributor license agreements. See theICE file
* distributed with this work for additional information
Review comment:
Seems to be an unexpected modification. Also has the same issue in the newly added files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12832: Extent filtered by other axis
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #12832:
URL: https://github.com/apache/incubator-echarts/pull/12832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12832: Extent filtered by other axis
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12832:
URL: https://github.com/apache/incubator-echarts/pull/12832#issuecomment-646542241
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org