You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2013/01/08 20:47:39 UTC
Review Request: Recent rpc changes are breaking gadget to gadget
communication
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8894/
-----------------------------------------------------------
Review request for shindig and Henry Saputra.
Description
-------
This makes the search for target frames a bit more resilient.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1430457
Diff: https://reviews.apache.org/r/8894/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Recent rpc changes are breaking gadget to gadget
communication
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8894/#review15164
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On Jan. 8, 2013, 7:47 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8894/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 7:47 p.m.)
>
>
> Review request for shindig and Henry Saputra.
>
>
> Description
> -------
>
> This makes the search for target frames a bit more resilient.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1430457
>
> Diff: https://reviews.apache.org/r/8894/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Recent rpc changes are breaking gadget to gadget
communication
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8894/#review15160
-----------------------------------------------------------
Ship it!
+1 Thanks for the fix! =)
- Henry Saputra
On Jan. 8, 2013, 7:47 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8894/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 7:47 p.m.)
>
>
> Review request for shindig and Henry Saputra.
>
>
> Description
> -------
>
> This makes the search for target frames a bit more resilient.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js 1430457
>
> Diff: https://reviews.apache.org/r/8894/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>