You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Tanay Banerjee <ta...@gmail.com> on 2020/02/08 15:13:37 UTC

Re: Incorrect param in Doc ref url:https://spark.apache.org/docs/latest/ml-datasource

> Hi Team,
>
> I have found out below incorrect code which will lead to error "NameError:
> name 'true' is not defined". As true is the the parameter required but
> 'True'
>
> All the details are provided below.
>
> URL: https://spark.apache.org/docs/latest/ml-datasource
>
> Issue:
>
> true -> TRUE
> df = spark.read.format("image").option("dropInvalid",
> true).load("data/mllib/images/origin/kittens")
>
> After Correction:
> df = spark.read.format("image").option("dropInvalid",
> True).load("data/mllib/images/origin/kittens")
>
> regards,
> Tanay
>

Re: Incorrect param in Doc ref url:https://spark.apache.org/docs/latest/ml-datasource

Posted by Tanay Banerjee <ta...@gmail.com>.
Thanks Sean.
I have just opened a pull request: Branch 2.4 #27500.



On Sat, 8 Feb 2020, 8:54 pm Sean Owen, <sr...@gmail.com> wrote:

> To be clear, you're referring to the Python version of the example.
> Yes it should be True.
> Can you open a pull request to fix it? the docs are under docs/ in the
> apache/spark github repo. That's how we normally take fixes.
>
> On Sat, Feb 8, 2020 at 9:14 AM Tanay Banerjee <ta...@gmail.com>
> wrote:
> >
> >
> >> Hi Team,
> >>
> >> I have found out below incorrect code which will lead to error
> "NameError: name 'true' is not defined". As true is the the parameter
> required but 'True'
> >>
> >> All the details are provided below.
> >>
> >> URL: https://spark.apache.org/docs/latest/ml-datasource
> >>
> >> Issue:
> >>
> >> true -> TRUE
> >> df = spark.read.format("image").option("dropInvalid",
> true).load("data/mllib/images/origin/kittens")
> >>
> >> After Correction:
> >> df = spark.read.format("image").option("dropInvalid",
> True).load("data/mllib/images/origin/kittens")
> >>
> >> regards,
> >> Tanay
>

Re: Incorrect param in Doc ref url:https://spark.apache.org/docs/latest/ml-datasource

Posted by Sean Owen <sr...@gmail.com>.
To be clear, you're referring to the Python version of the example.
Yes it should be True.
Can you open a pull request to fix it? the docs are under docs/ in the
apache/spark github repo. That's how we normally take fixes.

On Sat, Feb 8, 2020 at 9:14 AM Tanay Banerjee <ta...@gmail.com> wrote:
>
>
>> Hi Team,
>>
>> I have found out below incorrect code which will lead to error "NameError: name 'true' is not defined". As true is the the parameter required but 'True'
>>
>> All the details are provided below.
>>
>> URL: https://spark.apache.org/docs/latest/ml-datasource
>>
>> Issue:
>>
>> true -> TRUE
>> df = spark.read.format("image").option("dropInvalid", true).load("data/mllib/images/origin/kittens")
>>
>> After Correction:
>> df = spark.read.format("image").option("dropInvalid", True).load("data/mllib/images/origin/kittens")
>>
>> regards,
>> Tanay

---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org